Allow empty arrays as arguments #1154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
bug
|
@wesm can you review this when you get a chance? |
|
Not sure why some of the pieces of the circle build are not showing up as completed, even though they did in fact finish: https://circleci.com/workflow-run/312939e9-2ba8-4b7f-b0e5-1bef91570bb1. |
cpcloud
force-pushed
the
empty-arrays-as-arguments
branch
from
a71dbe8
to
0e4c03c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1153.
This PR fills out support for empty arrays as input arguments.
ibis.literal([])now returns an array of typearray<any>. Before this PR it raises an exception.array<any>to the required input type specified by the rule in theNodedefinition during argument validation.Nodesubclass acceptingrules.array(dt.int64)will acceptLiterals of typedt.Array(dt.any)