Add expressions for Map/Struct types and columns #1166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
feature
wesm
approved these changes
Oct 15, 2017
| (list('abc'), 'array<string>', ir.ArrayScalar), | ||
| ([1, 2, 3], 'array<int8>', ir.ArrayScalar), | ||
| ({'a': 1, 'b': 2, 'c': 3}, 'map<string, int8>', ir.MapScalar), | ||
| ({1: 2, 3: 4, 5: 6}, 'map<int8, int8>', ir.MapScalar), |
There was a problem hiding this comment.
Aside: I wonder how much we benefit / are hurt overall from aggressively choosing the smallest type integer that will fit the literal values vs. using int32 (unless some values are larger than INT32_MAX)
There was a problem hiding this comment.
Interesting, I tried to compute (2 ** 20) ** 200000 and got an overflow error. I think we should not try to infer the smallest integer type containing the result of an integer operation since it could take an unreasonably long amount of time to raise OverflowError.
There was a problem hiding this comment.
Yeah, the question is what is the benefit or cost (if any) of literal([1, 2, 3]) returning an array<int8> vs. array<int32>
| def factory(arg, name=None): | ||
| return ArrayScalar(arg, self.type(), name=name) | ||
| return factory | ||
|
|
cpcloud
force-pushed
the
complex-type-columns
branch
from
94fd309
to
006a98b
Compare
|
Merging on green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.