ENH/CLN: Fix DataType hashing #1172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
force-pushed
the
cleanup-hashing
branch
6 times, most recently
from
d92802d
to
89bcb86
Compare
cpcloud
force-pushed
the
cleanup-hashing
branch
4 times, most recently
from
c9a67d6
to
45f7ec7
Compare
|
@wesm can you review this when you get a chance? |
wesm
approved these changes
Oct 24, 2017
ibis/expr/datatypes.py
Outdated
| self._name = name | ||
| if not isinstance(schema, Schema): | ||
| raise TypeError( | ||
| 'schema argument to HasSchem class must be a Schema instance' |
| @@ -390,78 +415,79 @@ def valid_literal(self, value): | |||
|
|
|||
| class Int8(Integer): | |||
|
|
|||
| __slots__ = () | |||
There was a problem hiding this comment.
Do __slots__ inherit in any reasonable way? (I assume not)
There was a problem hiding this comment.
That's right. Stated here: https://docs.python.org/3.6/reference/datamodel.html#notes-on-using-slots
The action of a
__slots__declaration is limited to the class where it is defined. As a result, subclasses will have a__dict__unless they also define__slots__(which must only contain names of any additional slots).
|
Merging on green. |
cpcloud
force-pushed
the
cleanup-hashing
branch
3 times, most recently
from
92ca85b
to
daea4ca
Compare
cpcloud
force-pushed
the
cleanup-hashing
branch
from
daea4ca
to
3189e43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, every datatype's hash function was
hash(type(self)), whichmeans collisions galore (triggering eq comparison when using complex types
as dict keys). This PR provides a hash function based on
__slots__givingevery type a unique hash based on
type(self), its slots (if any) + thenullablefield from theDataTypeparent class.