Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Incorrect impala code generated for NOT with complex argument #1176

Closed
wants to merge 1 commit into from
Closed

BUG: Incorrect impala code generated for NOT with complex argument #1176

wants to merge 1 commit into from

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Oct 19, 2017

No description provided.

@cpcloud cpcloud self-assigned this Oct 19, 2017
@cpcloud cpcloud added the feature Features or general enhancements label Oct 19, 2017
@cpcloud cpcloud added this to the 0.12 milestone Oct 19, 2017
wesm
wesm approved these changes Oct 19, 2017
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@cpcloud
Copy link
Member Author

cpcloud commented Oct 20, 2017

Merging on green.

@cpcloud
Copy link
Member Author

cpcloud commented Oct 20, 2017

@wesm This was actually caught by @tsdlovell during bigquery backend dev. Thanks @tsdlovell!

@wesm
Copy link
Member

wesm commented Oct 20, 2017

nice, thanks @tsdlovell!

@cpcloud cpcloud closed this in f2737bf Oct 20, 2017
@cpcloud cpcloud deleted the fix-not branch October 20, 2017 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesm wesm wesm approved these changes

Assignees

@cpcloud cpcloud

Labels
feature Features or general enhancements
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @wesm