New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Incorrect impala code generated for NOT with complex argument #1176

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@cpcloud
Member

cpcloud commented Oct 19, 2017

No description provided.

@cpcloud cpcloud self-assigned this Oct 19, 2017

@cpcloud cpcloud added the enhancement label Oct 19, 2017

@cpcloud cpcloud added this to the 0.12 milestone Oct 19, 2017

@wesm

wesm approved these changes Oct 19, 2017

Nice catch

@cpcloud cpcloud force-pushed the cpcloud:fix-not branch from 9eec6b5 to ac6ae2c Oct 20, 2017

@cpcloud

This comment has been minimized.

Member

cpcloud commented Oct 20, 2017

Merging on green.

@cpcloud

This comment has been minimized.

Member

cpcloud commented Oct 20, 2017

@wesm This was actually caught by @tsdlovell during bigquery backend dev. Thanks @tsdlovell!

@cpcloud cpcloud force-pushed the cpcloud:fix-not branch from ac6ae2c to 4ab35d3 Oct 20, 2017

@wesm

This comment has been minimized.

Member

wesm commented Oct 20, 2017

nice, thanks @tsdlovell!

@cpcloud cpcloud closed this in f2737bf Oct 20, 2017

@cpcloud cpcloud deleted the cpcloud:fix-not branch Oct 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment