BUG: Fix sort_by codegen and repeated compilation issue #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
force-pushed
the
fix-order-by-count
branch
3 times, most recently
from
a307b22
to
074e6c9
Compare
|
@wesm can you review this when you get a chance? |
|
will do |
wesm
approved these changes
Oct 24, 2017
| expr.compile().compile(compile_kwargs={'literal_binds': True}) | ||
| ) | ||
| expected = """\ | ||
| SELECT count('*') AS count |
There was a problem hiding this comment.
This is the count-star syntax for sqlite, I guess (did not know that)?
There was a problem hiding this comment.
Hm, actually this will have the same behavior as count(*) except in the case of an empty table. I need to fix this.
There was a problem hiding this comment.
Actually, nevermind. This is the form suggested by the SQLAlchemy docs.
cpcloud
force-pushed
the
fix-order-by-count
branch
from
074e6c9
to
1157257
Compare
cpcloud
force-pushed
the
fix-order-by-count
branch
from
1157257
to
f1e2ebe
Compare
|
Thanks for the review @wesm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1179
Closes #1180