ENH: Add binary data type #1183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesm
approved these changes
Oct 23, 2017
| @@ -305,6 +305,12 @@ def valid_literal(self, value): | |||
| return isinstance(value, six.string_types) | |||
|
|
|||
|
|
|||
| class Binary(Variadic): | |||
There was a problem hiding this comment.
May be worth now adding a docstring to contrast string vs. binary. Though the definition of "string" may vary from back end to back end (e.g. we cannot necessarily rely on it being utf8)
cpcloud
force-pushed
the
binary-type
branch
2 times, most recently
from
2e3c700
to
5a6b7be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.