ENH/API: Add where to nunique reduction #1220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
feature
cpcloud
commented
Nov 6, 2017
ibis/expr/api.py
Outdated
|
|
||
| Parameters | ||
| ----------- | ||
| expr : ibis.expr.types.Expr |
There was a problem hiding this comment.
Need to add a where parameter here.
cpcloud
commented
Nov 6, 2017
ibis/impala/compiler.py
Outdated
| arg, where = expr.op().args | ||
|
|
||
| if where is not None: | ||
| arg_formatted = translator.translate(arg.ifelse(where, None)) |
There was a problem hiding this comment.
This should be where.ifelse(arg, None).
cpcloud
force-pushed
the
count-distinct-filter
branch
from
05c9b57
to
ad2e5e9
Compare
cpcloud
force-pushed
the
count-distinct-filter
branch
from
ad2e5e9
to
e62c396
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.