New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH/API: Add where to nunique reduction #1220

Closed
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@cpcloud
Member

cpcloud commented Nov 6, 2017

No description provided.

@cpcloud cpcloud self-assigned this Nov 6, 2017

@cpcloud cpcloud added this to the 0.13 milestone Nov 6, 2017

Parameters
-----------
expr : ibis.expr.types.Expr

This comment has been minimized.

@cpcloud

cpcloud Nov 6, 2017

Member

Need to add a where parameter here.

arg, where = expr.op().args
if where is not None:
arg_formatted = translator.translate(arg.ifelse(where, None))

This comment has been minimized.

@cpcloud

cpcloud Nov 6, 2017

Member

This should be where.ifelse(arg, None).

@cpcloud cpcloud force-pushed the cpcloud:count-distinct-filter branch from 05c9b57 to ad2e5e9 Nov 12, 2017

@cpcloud cpcloud force-pushed the cpcloud:count-distinct-filter branch from ad2e5e9 to e62c396 Nov 20, 2017

cpcloud added some commits Nov 20, 2017

@cpcloud cpcloud closed this in 0b6aeaf Nov 22, 2017

@cpcloud cpcloud deleted the cpcloud:count-distinct-filter branch Nov 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment