Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interval quarter #1259

Closed
wants to merge 5 commits into from
Closed

Interval quarter #1259

wants to merge 5 commits into from

Conversation

kszucs
Copy link
Member

@kszucs kszucs commented Dec 10, 2017 •
edited
Loading

  • quarter support
  • allowed conversion between year - quarter - month
  • named test cases

resolves #1252

@cpcloud cpcloud self-requested a review December 10, 2017 18:42
@cpcloud cpcloud added this to the 0.13 milestone Dec 10, 2017
cpcloud
cpcloud approved these changes Dec 10, 2017
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

ci/datamgr.py Outdated
engine.execute('VACUUM')
engine.execute('VACUUM ANALYZE')
# engine.execute('VACUUM')
# engine.execute('VACUUM ANALYZE')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to kill these lines.

@cpcloud cpcloud added feature Features or general enhancements expressions Issues or PRs related to the expression API labels Dec 10, 2017
@cpcloud
Copy link
Member

cpcloud commented Dec 10, 2017

@kszucs Can you add a release note to docs/source/release.rst? Then will merge.

@cpcloud
Copy link
Member

cpcloud commented Dec 11, 2017

@kszucs can you rebase and resolve the tiny doc conflict? i will merge after that

@kszucs
Copy link
Member Author

kszucs commented Dec 11, 2017

@cpcloud done

@cpcloud cpcloud closed this in 1e7c457 Dec 11, 2017
@kszucs kszucs deleted the interval-quarter branch December 29, 2017 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees

@kszucs kszucs

Labels
expressions Issues or PRs related to the expression API feature Features or general enhancements
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.

Add support for an interval with a quarter period
2 participants
@kszucs @cpcloud