New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interval quarter #1259

Closed
wants to merge 5 commits into
base: master
from

Conversation

2 participants
@kszucs
Member

kszucs commented Dec 10, 2017

  • quarter support
  • allowed conversion between year - quarter - month
  • named test cases

resolves #1252

@cpcloud cpcloud self-requested a review Dec 10, 2017

@cpcloud cpcloud added this to To do in Interval Type via automation Dec 10, 2017

@cpcloud cpcloud added this to the 0.13 milestone Dec 10, 2017

@cpcloud

+1 LGTM

engine.execute('VACUUM')
engine.execute('VACUUM ANALYZE')
# engine.execute('VACUUM')
# engine.execute('VACUUM ANALYZE')

This comment has been minimized.

@cpcloud

cpcloud Dec 10, 2017

Member

It's fine to kill these lines.

@cpcloud

This comment has been minimized.

Member

cpcloud commented Dec 10, 2017

@kszucs Can you add a release note to docs/source/release.rst? Then will merge.

@kszucs kszucs force-pushed the kszucs:interval-quarter branch from aad0b83 to 55f6d3c Dec 10, 2017

@cpcloud

This comment has been minimized.

Member

cpcloud commented Dec 11, 2017

@kszucs can you rebase and resolve the tiny doc conflict? i will merge after that

@kszucs kszucs force-pushed the kszucs:interval-quarter branch from da5cdde to 3e6d6e4 Dec 11, 2017

@kszucs

This comment has been minimized.

Member

kszucs commented Dec 11, 2017

@cpcloud done

@cpcloud cpcloud closed this in 1e7c457 Dec 11, 2017

Interval Type automation moved this from To do to Done Dec 11, 2017

@kszucs kszucs deleted the kszucs:interval-quarter branch Dec 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment