New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: can't mutate and then drop #1299

Closed
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@cpcloud
Member

cpcloud commented Jan 24, 2018

closes #1296

The issue is that _maybe_resolve_exprs was not ignoring columns that don't exist in a child Selection so it would try to resolve them and throw an IbisTypeError. This is okay, because the expressions have already been resolved in the Projector constructor so trying to project a column that doesn't anywhere would raise this exception long before getting to _maybe_resolve_exprs.

@cpcloud cpcloud self-assigned this Jan 24, 2018

@cpcloud cpcloud added the bug label Jan 24, 2018

@cpcloud cpcloud added this to the 0.13 milestone Jan 24, 2018

@wesm

wesm approved these changes Jan 25, 2018

+1

@cpcloud cpcloud force-pushed the cpcloud:fix-drop branch from 21a0d85 to 35da426 Jan 25, 2018

@cpcloud

This comment has been minimized.

Member

cpcloud commented Jan 25, 2018

merging on green

@cpcloud cpcloud force-pushed the cpcloud:fix-drop branch from 35da426 to 289fcf8 Jan 25, 2018

@cpcloud

This comment has been minimized.

Member

cpcloud commented Jan 26, 2018

merging after rebase and green

@cpcloud cpcloud force-pushed the cpcloud:fix-drop branch from 84056f3 to 123b156 Jan 27, 2018

@cpcloud cpcloud closed this in 65de6c2 Jan 28, 2018

@cpcloud cpcloud deleted the cpcloud:fix-drop branch Jan 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment