Docker Compose based CI setup #1311
Conversation
| - IBIS_TEST_CLICKHOUSE_PORT=9000 | ||
| - IBIS_TEST_CLICKHOUSE_DATABASE=ibis_testing | ||
| - GOOGLE_BIGQUERY_PROJECT_ID=ibis-gbq | ||
| - GOOGLE_APPLICATION_CREDENTIALS=/tmp/gcloud-service-key.json |
There was a problem hiding this comment.
This needs to be /tmp/ibis/gcloud-service-key.json to match the shell commands.
There was a problem hiding this comment.
In the volumes section /tmp/ibis host directory is mounted at /tmp inside the container.
There was a problem hiding this comment.
Cool, didn't catch that (even though it's right below). Thanks for pointing it out.
ci/docker-compose.yml
Outdated
| context: .. | ||
| dockerfile: ci/Dockerfile | ||
| args: | ||
| PYTHON: ${PYTHON_VERSION-3.6} |
There was a problem hiding this comment.
Let's use the ${parameter:-word} syntax so that this will substitute word if parameter is null.
| @@ -243,7 +243,7 @@ def load(data, udf, data_dir, overwrite): | |||
| try: | |||
| load_impala_data(con, data_dir, overwrite) | |||
| finally: | |||
| shutil.rmtree(tmp_dir) | |||
kszucs
changed the title
|
@cpcloud It's ready on my side. You might cancel the appveyor build except the last one. |
|
appveyor build passing here: https://ci.appveyor.com/project/kszucs/ibis/build/1.0.507 |
|
thanks @kszucs great work! |
|
Cool stuff! I also enjoyed the commit messages |
|
Thanks! The development guide probably needs an update too. |
TODO: