BUG: Handle large timestamps #1440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kszucs
reviewed
May 2, 2018
| dt.Decimal: 'float64', | ||
| dt.Struct: 'object', | ||
| } | ||
| _ibis_dtypes = toolz.valmap( |
kszucs
reviewed
May 2, 2018
ibis/pandas/client.py
Outdated
| df[column] = col.values.astype(pandas_dtype) | ||
| elif isinstance(dtype, dt.Timestamp): | ||
| # input column has a timezone | ||
| timezone = dtype.timezone |
There was a problem hiding this comment.
Uhh, this seems complex, there are 5 possible outcomes in case of timestamps.
How about factoring this out with slightly more comments?
cpcloud
added
bug
cpcloud
force-pushed
the
fix-bigquery-large-timestamps
branch
from
ccf6343
to
55731bd
Compare
cpcloud
force-pushed
the
fix-bigquery-large-timestamps
branch
from
55731bd
to
74902a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.