BUG/CI/TST: Fix compatibility with pandas 0.23 #1458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandas 0.23 changed the default behavior of the `chunksize` argument which breaks SQLite when loading a large dataset because SQLite has an upper bound on the number of rows in a single insert statement. This PR works around that our `ci/datamgr.py` script so that we can get master back to green.
cpcloud
added
bug
cpcloud
changed the title
|
@missing-semicolon, this is all passing locally, and running on CI uncached so if this passes we can finally make some forward progress on other issues. |
|
@missing-semicolon also if you want to review anything, feel free |
|
passing appveyor build here: https://ci.appveyor.com/project/cpcloud/ibis/build/1.0.1569 |
|
Merging this on green. |
This was referenced Jun 1, 2018
|
merging |
cpcloud
added a commit
that referenced
this pull request
Jun 6, 2018
Depends on #1458 Closes #1465 Author: Phillip Cloud <cpcloud@gmail.com> Closes #1466 from cpcloud/add-pandas-versions and squashes the following commits: 4a6a9ba [Phillip Cloud] Strings for paths on python2 and older pandas 3f8ad28 [Phillip Cloud] Revert compat changes and fix lint issues 8f08b81 [Phillip Cloud] Use item to get the python value of a numpy scalar out 53b079d [Phillip Cloud] ENH/CI: Add pandas 0.20, 0.22 to ci builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas 0.23 changed the default behavior of the
chunksizeargumentwhich breaks SQLite when loading a large dataset because SQLite has an
upper bound on the number of rows in a single insert statement.
This PR works around that our
ci/datamgr.pyscript so that we can getmaster back to green.