ENH/BUG: Fix broken decimal type support #1541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
force-pushed
the
fix-decimal-support
branch
from
439ad27
to
cfcde6a
Compare
cpcloud
force-pushed
the
fix-decimal-support
branch
from
cfcde6a
to
b162072
Compare
kszucs
reviewed
Jul 16, 2018
| @@ -9,7 +9,7 @@ RUN apt-get -qq update -y \ | |||
| ARG PYTHON | |||
| ARG ENVKIND | |||
|
|
|||
| ADD ci/requirements-${ENVKIND}-${PYTHON}.yml / | |||
| COPY ci/requirements-${ENVKIND}-${PYTHON}.yml / | |||
kszucs
reviewed
Jul 16, 2018
| dtype = arg.type() | ||
| else: | ||
| dtype = dt.double | ||
| return rlz.shape_like(arg, dtype) |
There was a problem hiding this comment.
Semantically this is equivalent with
dtype = dt.highest_precedence([self.arg.type(), dt.double])probably faster though
There was a problem hiding this comment.
Which reminds me, We might decorate dt.highest_precedence with functools.lru_cache
cpcloud
added a commit
that referenced
this pull request
Jul 17, 2018
Closes #1534 Depends on #1541 Author: Phillip Cloud <cpcloud@gmail.com> Closes #1535 from cpcloud/add-bq-numeric and squashes the following commits: 03e7706 [Phillip Cloud] Remove unused variable db5318e [Phillip Cloud] Cleanup dispatch 97675ea [Phillip Cloud] Add support for NUMERIC in the BigQuery backend 2 7012efe [Phillip Cloud] Add support for NUMERIC in the BigQuery backend 990d6fd [Phillip Cloud] Add datamgr numeric_table creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of places where we are computing the incorrect
output_typefor some operations as well as computing afloat64output type for operations whose inputs are decimals. Impala explicitly does this and so does BigQuery. The upshot of this is that whenschema.apply_to(result)is called in these backends we will convert the data (which will befloat64Seriesobjects) intoDecimalcolumns.