BUG: Fix equality #1600
BUG: Fix equality #1600
Conversation
cpcloud
force-pushed
the
fix-equality
branch
from
035895b
to
9334c23
Compare
|
@kszucs can you review this PR when you get a chance? |
| if self.equals(other): | ||
| return True | ||
|
|
||
| fn = lambda e: (lin.proceed, e.op()) # noqa: E731 |
There was a problem hiding this comment.
Perhaps It'd be useful to factor out this block to a lin.flatten function. I start to like even more this lin.traverse :)
There was a problem hiding this comment.
Cool, can you open an issue for that?
| ), | ||
| t2 AS ( | ||
| ) | ||
| SELECT t2.* |
There was a problem hiding this comment.
Reviewing SQL string is surprisingly hard, but it looks way better.
| FROM t0 | ||
| WHERE t0.`o_totalprice` > ( | ||
| SELECT avg(t7.`o_totalprice`) AS `mean` | ||
| FROM t0 t7 |
There was a problem hiding this comment.
At first it looks odd. If I'm correct t0 is tpch and t7 is tpch.view(), so it's actually correct.
|
@cpcloud Should I merge? |
ibis/expr/operations.py
Outdated
| if hasattr(left, 'equals'): | ||
| return left.equals(right, cache=cache) | ||
| return left == right | ||
| return (hasattr(left, 'equals') and |
There was a problem hiding this comment.
IMO the previous was more readable.
|
The tests broke. |
|
Yeah, using |
|
Merging on green. |
|
@cpcloud I've recently updated the |
|
@kszucs Is this why the |
|
Ok, it's still failing. I need to leave the openoffice now, I'll be in front of keyboard again in 30m.. |
|
Re. I'm reproducing it locally, now that I have bandwith. |
|
@cpcloud Please restart your builds, should(!!!) work now! |
|
@kszucs Excellent, thanks for digging in. |
Closes #1599
This is a temporary fix that preserves most existing behavior until we can
refactor the compiler to separate compilation from optimization.