ENH/BUG: Support string slicing with other expressions #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
bug
cpcloud
force-pushed
the
fix-str-slice
branch
from
801b858
to
054f5b0
Compare
|
@kszucs Can you give this a review when you get a chance? |
kszucs
reviewed
Sep 19, 2018
ibis/expr/api.py
Outdated
| raise ValueError('negative slicing not yet supported') | ||
| if not isinstance(stop, ir.Expr): | ||
| if stop is not None and stop < 0: | ||
| raise ValueError('negative slicing not yet supported') |
kszucs
reviewed
Sep 19, 2018
ibis/expr/api.py
Outdated
| if stop is not None and stop < 0: | ||
| raise ValueError('negative slicing not yet supported') | ||
| if stop is None: | ||
| stop = self.length() |
There was a problem hiding this comment.
Minor, just not consistent with the previous validation order.
There was a problem hiding this comment.
I don't follow, what was the previous validation order?
kszucs
reviewed
Sep 19, 2018
kszucs
reviewed
Sep 19, 2018
ibis/pandas/execution/strings.py
Outdated
| def execute_string_substring_series_series(op, data, start, length, **kwargs): | ||
| end = start + length | ||
|
|
||
| def iterate(value, |
There was a problem hiding this comment.
This "general" case wouldn't be enough?
There was a problem hiding this comment.
I suppose we could farm out the other functions to this one.
There was a problem hiding this comment.
We definitely need to handle the integer, series and series, integer cases distinctly, but those two can be made to be instances of the general case.
kszucs
reviewed
Sep 19, 2018
kszucs
reviewed
Sep 19, 2018
ibis/expr/api.py
Outdated
| if start is None: | ||
| start = 0 | ||
| if start < 0: | ||
| raise ValueError('Negative slicing not yet supported') |
There was a problem hiding this comment.
Crossed out because of this comment.
cpcloud
force-pushed
the
fix-str-slice
branch
from
b562d92
to
c8a8867
Compare
cpcloud
force-pushed
the
fix-str-slice
branch
from
c8a8867
to
2494069
Compare
kszucs
reviewed
Sep 19, 2018
kszucs
approved these changes
Sep 19, 2018
|
Merging on green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1626