Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Fix UDF bugs in the pandas backend #1637

Closed
wants to merge 8 commits into from

Conversation

Projects
3 participants
@cpcloud
Copy link
Member

cpcloud commented Sep 26, 2018

Also adds support for non-aggregate analytic functions

Closes #1633

@cpcloud cpcloud added this to the Next Release milestone Sep 26, 2018

@cpcloud cpcloud added this to To do in UDFs via automation Sep 26, 2018

@cpcloud cpcloud requested a review from kszucs Sep 26, 2018

@cpcloud

This comment has been minimized.

Copy link
Member Author

cpcloud commented Sep 26, 2018

@kszucs

This comment has been minimized.

Copy link
Member

kszucs commented Sep 27, 2018

Flake8 misses configparser on py27.

@cpcloud

This comment has been minimized.

Copy link
Member Author

cpcloud commented Sep 27, 2018

Something might be buggy in the installation process because that line of code has been in flake8 for ages. Also, configparser is installed on the machine. I'll look into it.

@cpcloud

This comment has been minimized.

Copy link
Member Author

cpcloud commented Sep 27, 2018

Looks like it might be fixed conda-forge/configparser-feedstock#16

Show resolved Hide resolved ibis/pandas/tests/test_udf.py Outdated
Show resolved Hide resolved ibis/pandas/udf.py Outdated

@cpcloud cpcloud force-pushed the cpcloud:fix-pandas-udfs branch from a35641e to f5d0cfa Sep 27, 2018

Show resolved Hide resolved ibis/pandas/udf.py Outdated
Show resolved Hide resolved ibis/pandas/udf.py Outdated
Show resolved Hide resolved ibis/pandas/udf.py Outdated
Show resolved Hide resolved ibis/pandas/tests/test_udf.py Outdated
@kszucs

This comment has been minimized.

Copy link
Member

kszucs commented Sep 27, 2018

AFAICT pandas udf module does two things: function style operation definition and its mapping to multipledispatch signatures. I think the first one should be factored out to ibis.expr.

@cpcloud

This comment has been minimized.

Copy link
Member Author

cpcloud commented Sep 27, 2018

@kszucs

AFAICT pandas udf module does two things: function style operation definition and its mapping to multipledispatch signatures.

Indeed.

I think the first one should be factored out to ibis.expr.

I'll make an issue to discuss the design here. Do you want to take the lead on designing/implementing that?

@kszucs

This comment has been minimized.

Copy link
Member

kszucs commented Sep 27, 2018

@cpcloud sure yes!

Show resolved Hide resolved ibis/pandas/api.py
Show resolved Hide resolved ibis/pandas/tests/test_udf.py Outdated
Show resolved Hide resolved ibis/pandas/udf.py
Show resolved Hide resolved ibis/pandas/udf.py Outdated
Show resolved Hide resolved ibis/pandas/udf.py Outdated
Show resolved Hide resolved ibis/pandas/udf.py Outdated
Show resolved Hide resolved ibis/pandas/udf.py Outdated
Show resolved Hide resolved ibis/pandas/udf.py Outdated

@cpcloud cpcloud force-pushed the cpcloud:fix-pandas-udfs branch 2 times, most recently from 0536f15 to 5956764 Oct 2, 2018

@cpcloud cpcloud force-pushed the cpcloud:fix-pandas-udfs branch from a73b0bc to 33c3d54 Oct 2, 2018

Show resolved Hide resolved ibis/pandas/udf.py

cpcloud added some commits Oct 3, 2018

@cpcloud cpcloud closed this in 6699c60 Oct 3, 2018

UDFs automation moved this from To do to Done Oct 3, 2018

@cpcloud cpcloud deleted the cpcloud:fix-pandas-udfs branch Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.