Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Fix UDF bugs in the pandas backend #1637

Closed
wants to merge 8 commits into from
Closed

ENH: Fix UDF bugs in the pandas backend #1637

wants to merge 8 commits into from

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Sep 26, 2018 •
edited
Loading

Also adds support for non-aggregate analytic functions

Closes #1633

@cpcloud cpcloud added this to the Next Release milestone Sep 26, 2018
@cpcloud cpcloud requested a review from kszucs September 26, 2018 21:14
@cpcloud
Copy link
Member Author

cpcloud commented Sep 26, 2018

cc @DiegoAlbertoTorres

@kszucs
Copy link
Member

kszucs commented Sep 27, 2018

Flake8 misses configparser on py27.

@cpcloud
Copy link
Member Author

cpcloud commented Sep 27, 2018

Something might be buggy in the installation process because that line of code has been in flake8 for ages. Also, configparser is installed on the machine. I'll look into it.

@cpcloud
Copy link
Member Author

cpcloud commented Sep 27, 2018

Looks like it might be fixed conda-forge/configparser-feedstock#16

kszucs
kszucs reviewed Sep 27, 2018
View reviewed changes
ibis/pandas/udf.py Outdated Show resolved Hide resolved
kszucs
kszucs reviewed Sep 27, 2018
View reviewed changes
ibis/pandas/udf.py Outdated Show resolved Hide resolved
ibis/pandas/udf.py Outdated Show resolved Hide resolved
ibis/pandas/udf.py Outdated Show resolved Hide resolved
@kszucs
Copy link
Member

kszucs commented Sep 27, 2018

AFAICT pandas udf module does two things: function style operation definition and its mapping to multipledispatch signatures. I think the first one should be factored out to ibis.expr.

@cpcloud
Copy link
Member Author

cpcloud commented Sep 27, 2018

@kszucs

AFAICT pandas udf module does two things: function style operation definition and its mapping to multipledispatch signatures.

Indeed.

I think the first one should be factored out to ibis.expr.

I'll make an issue to discuss the design here. Do you want to take the lead on designing/implementing that?

@kszucs
Copy link
Member

kszucs commented Sep 27, 2018

@cpcloud sure yes!

@cpcloud cpcloud mentioned this pull request Sep 27, 2018
Closed
DiegoAlbertoTorres
DiegoAlbertoTorres reviewed Sep 28, 2018
View reviewed changes
ibis/pandas/api.py Show resolved Hide resolved
ibis/pandas/tests/test_udf.py Outdated Show resolved Hide resolved
ibis/pandas/udf.py Show resolved Hide resolved
ibis/pandas/udf.py Outdated Show resolved Hide resolved
ibis/pandas/udf.py Outdated Show resolved Hide resolved
ibis/pandas/udf.py Outdated Show resolved Hide resolved
ibis/pandas/udf.py Outdated Show resolved Hide resolved
ibis/pandas/udf.py Outdated Show resolved Hide resolved
@cpcloud cpcloud force-pushed the fix-pandas-udfs branch 2 times, most recently from 0536f15 to 5956764 Compare October 2, 2018 16:24
@cpcloud cpcloud closed this in 6699c60 Oct 3, 2018
@cpcloud cpcloud deleted the fix-pandas-udfs branch October 3, 2018 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kszucs kszucs kszucs left review comments

@DiegoAlbertoTorres DiegoAlbertoTorres DiegoAlbertoTorres left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cpcloud @kszucs @DiegoAlbertoTorres