Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MapD server-CI #1641

Closed
wants to merge 4 commits into from
Closed

Updated MapD server-CI #1641

wants to merge 4 commits into from

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Sep 30, 2018

Updated MapD Server/CI

@cpcloud cpcloud added this to the Next Release milestone Sep 30, 2018
@cpcloud cpcloud added ci Continuous Integration issues or PRs mapd labels Sep 30, 2018
@cpcloud cpcloud self-requested a review September 30, 2018 23:50
@cpcloud
Copy link
Member

cpcloud commented Oct 1, 2018

@xmnlab Can you rebase to pick up the azure pipelines change?

@codecov
Copy link

codecov bot commented Oct 1, 2018

Codecov Report

Merging #1641 into master will decrease coverage by 2.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1641      +/-   ##
==========================================
- Coverage   89.87%   87.24%   -2.63%     
==========================================
  Files         185      185              
  Lines       27087    27085       -2     
  Branches     2328     2328              
==========================================
- Hits        24344    23631     -713     
- Misses       2337     3046     +709     
- Partials      406      408       +2
Impacted Files Coverage Δ
ibis/bigquery/tests/test_client.py 25.87% <0%> (-73.55%) ⬇️
ibis/bigquery/tests/test_compiler.py 37.56% <0%> (-62.44%) ⬇️
ibis/bigquery/udf/tests/test_udf_execute.py 28% <0%> (-54%) ⬇️
ibis/bigquery/client.py 42.91% <0%> (-52.37%) ⬇️
ibis/bigquery/compiler.py 58.82% <0%> (-38.61%) ⬇️
ibis/bigquery/tests/conftest.py 70.27% <0%> (-16.22%) ⬇️
ibis/bigquery/udf/api.py 80.48% <0%> (-14.64%) ⬇️
ibis/impala/compiler.py 91.04% <0%> (-5.75%) ⬇️
ibis/tests/all/test_temporal.py 95.45% <0%> (-4.55%) ⬇️
ibis/pandas/client.py 85.54% <0%> (-3.47%) ⬇️
... and 9 more

@xmnlab
Copy link
Contributor Author

xmnlab commented Oct 1, 2018

@cpcloud sure! done! 👍

@xmnlab
Copy link
Contributor Author

xmnlab commented Oct 1, 2018

@cpcloud it seems there is some error with azure conda upload ... any idea how to deal with this problem?

@cpcloud
Copy link
Member

cpcloud commented Oct 1, 2018

@xmnlab Working on it over here: #1642

@cpcloud
Copy link
Member

cpcloud commented Oct 1, 2018

@xmnlab Can you rebase again?

@xmnlab
Copy link
Contributor Author

xmnlab commented Oct 1, 2018

@cpcloud sure! done! thanks!

@cpcloud
Copy link
Member

cpcloud commented Oct 2, 2018

LGTM, merging on green.

@cpcloud cpcloud self-assigned this Oct 2, 2018
@xmnlab
Copy link
Contributor Author

xmnlab commented Oct 2, 2018

green :)

@cpcloud cpcloud closed this in e1e641f Oct 2, 2018
@cpcloud
Copy link
Member

cpcloud commented Oct 2, 2018

Thanks @xmnlab

@xmnlab xmnlab deleted the change_mapd_ci_to_v4_1_3 branch March 27, 2019 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants