Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove parameters from mapd Fixes #1610 #1648

Closed
wants to merge 6 commits into from
Closed

Remove parameters from mapd Fixes #1610 #1648

wants to merge 6 commits into from

Conversation

tonyfast
Copy link
Contributor

@tonyfast tonyfast commented Oct 6, 2018 •
edited by cpcloud
Loading

Closes #1610

@codecov
Copy link

codecov bot commented Oct 6, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@ac38ada). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1648   +/-   ##
========================================
  Coverage          ?   87.3%           
========================================
  Files             ?     185           
  Lines             ?   27154           
  Branches          ?    2335           
========================================
  Hits              ?   23707           
  Misses            ?    3041           
  Partials          ?     406
Impacted Files Coverage Δ
ibis/mapd/ddl.py 37.71% <0%> (ø)

@cpcloud
Copy link
Member

cpcloud commented Oct 7, 2018

@tonyfast Can you add a test that hits this code?

@tonyfast
Copy link
Contributor Author

@cpcloud I tried to add some tests. I am receiving some errors that I don't completely understand. Do I need to add some skip expressions somewhere?

@cpcloud
Copy link
Member

cpcloud commented Oct 10, 2018

@tonyfast Can you kick off the build again?

@tonyfast tonyfast closed this Oct 10, 2018
@tonyfast tonyfast reopened this Oct 10, 2018
xmnlab
xmnlab reviewed Oct 11, 2018
View reviewed changes
ibis/mapd/tests/conftest.py
yield name
finally:
assert con.exists_table(name), name
con.drop_table(name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonyfast not sure why but in the past I had some problems with drop function that broke the mapd server on CI

@cpcloud
Copy link
Member

cpcloud commented Oct 12, 2018

@tonyfast Please rebase on master, and you should have a green build assuming your tests are passing.

@cpcloud cpcloud added bug Incorrect behavior inside of ibis mapd labels Oct 12, 2018
@cpcloud cpcloud added this to the Next Release milestone Oct 12, 2018
@tonyfast
Copy link
Contributor Author

Thanks for the fixes @cpcloud . It looks like things are passing now.

@cpcloud
Copy link
Member

cpcloud commented Oct 16, 2018

@tonyfast Does this have an associated issue that should closed?

@tonyfast
Copy link
Contributor Author

Closes #1610

@cpcloud cpcloud closed this in 36de943 Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmnlab xmnlab xmnlab left review comments

Assignees
No one assigned
Labels
bug Incorrect behavior inside of ibis
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyfast @cpcloud @xmnlab