Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parameters from mapd Fixes #1610 #1648

Closed
wants to merge 6 commits into from

Conversation

Projects
3 participants
@tonyfast
Copy link
Contributor

tonyfast commented Oct 6, 2018

Closes #1610

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 6, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@ac38ada). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1648   +/-   ##
========================================
  Coverage          ?   87.3%           
========================================
  Files             ?     185           
  Lines             ?   27154           
  Branches          ?    2335           
========================================
  Hits              ?   23707           
  Misses            ?    3041           
  Partials          ?     406
Impacted Files Coverage Δ
ibis/mapd/ddl.py 37.71% <0%> (ø)
@cpcloud

This comment has been minimized.

Copy link
Member

cpcloud commented Oct 7, 2018

@tonyfast Can you add a test that hits this code?

@tonyfast

This comment has been minimized.

Copy link
Contributor Author

tonyfast commented Oct 10, 2018

@cpcloud I tried to add some tests. I am receiving some errors that I don't completely understand. Do I need to add some skip expressions somewhere?

@cpcloud

This comment has been minimized.

Copy link
Member

cpcloud commented Oct 10, 2018

@tonyfast Can you kick off the build again?

@tonyfast tonyfast closed this Oct 10, 2018

@tonyfast tonyfast reopened this Oct 10, 2018

yield name
finally:
assert con.exists_table(name), name
con.drop_table(name)

This comment has been minimized.

Copy link
@xmnlab

xmnlab Oct 11, 2018

Collaborator

@tonyfast not sure why but in the past I had some problems with drop function that broke the mapd server on CI

@cpcloud

This comment has been minimized.

Copy link
Member

cpcloud commented Oct 12, 2018

@tonyfast Please rebase on master, and you should have a green build assuming your tests are passing.

@cpcloud cpcloud added bug mapd labels Oct 12, 2018

@cpcloud cpcloud added this to In progress in MapD via automation Oct 12, 2018

@cpcloud cpcloud added this to the Next Release milestone Oct 12, 2018

@tonyfast

This comment has been minimized.

Copy link
Contributor Author

tonyfast commented Oct 13, 2018

Thanks for the fixes @cpcloud . It looks like things are passing now.

@cpcloud

This comment has been minimized.

Copy link
Member

cpcloud commented Oct 16, 2018

@tonyfast Does this have an associated issue that should closed?

@tonyfast

This comment has been minimized.

Copy link
Contributor Author

tonyfast commented Oct 16, 2018

Closes #1610

@cpcloud cpcloud closed this in 36de943 Oct 16, 2018

MapD automation moved this from In progress to Done Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.