Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Add test for reduction returning lists #1650

Closed
wants to merge 2 commits into from
Closed

TST: Add test for reduction returning lists #1650

wants to merge 2 commits into from

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Oct 9, 2018 •
edited
Loading

Closes #1649

@cpcloud cpcloud added the tests Issues or PRs related to tests label Oct 9, 2018
@cpcloud cpcloud added this to the Next Release milestone Oct 9, 2018
kszucs
kszucs approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kszucs
Copy link
Member

kszucs commented Oct 10, 2018

@cpcloud I don't have permissions to merge. BTW do You use the merge-pr.py tool or just squash-and-merge on the UI? Because these lines are suspicios https://github.com/ibis-project/ibis/blob/master/dev/merge-pr.py#L50

@cpcloud
Copy link
Member Author

cpcloud commented Oct 10, 2018

@kszucs I use the merge-pr.py script. Those links trigger a redirect because ibis was at one point under the pandas-dev organization.

@cpcloud cpcloud closed this in 6f64dc2 Oct 10, 2018
@cpcloud cpcloud deleted the fix-nested-analytic branch October 10, 2018 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kszucs kszucs kszucs approved these changes

Assignees
No one assigned
Labels
tests Issues or PRs related to tests
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @kszucs