Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Add test for reduction returning lists #1650

Closed
wants to merge 2 commits into from

Conversation

Projects
2 participants
@cpcloud
Copy link
Member

commented Oct 9, 2018

Closes #1649

cpcloud added some commits Oct 9, 2018

@cpcloud cpcloud added the testing label Oct 9, 2018

@cpcloud cpcloud added this to the Next Release milestone Oct 9, 2018

@cpcloud cpcloud added this to To do in Pandas via automation Oct 9, 2018

@kszucs

kszucs approved these changes Oct 9, 2018

Copy link
Member

left a comment

LGTM

@kszucs

This comment has been minimized.

Copy link
Member

commented Oct 10, 2018

@cpcloud I don't have permissions to merge. BTW do You use the merge-pr.py tool or just squash-and-merge on the UI? Because these lines are suspicios https://github.com/ibis-project/ibis/blob/master/dev/merge-pr.py#L50

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2018

@kszucs I use the merge-pr.py script. Those links trigger a redirect because ibis was at one point under the pandas-dev organization.

@cpcloud cpcloud closed this in 6f64dc2 Oct 10, 2018

Pandas automation moved this from To do to Done Oct 10, 2018

@cpcloud cpcloud deleted the cpcloud:fix-nested-analytic branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.