Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we cast when NULL is else in CASE expressions #1651

Closed
wants to merge 9 commits into from

Conversation

Projects
2 participants
@cpcloud
Copy link
Member

cpcloud commented Oct 9, 2018

cc @xmnlab

Closes #1620

@cpcloud cpcloud requested a review from kszucs Oct 9, 2018

@cpcloud cpcloud added this to To do in Refactoring via automation Oct 9, 2018

@cpcloud cpcloud added this to the Next Release milestone Oct 9, 2018

@kszucs

This comment has been minimized.

Copy link
Member

kszucs commented Oct 10, 2018

@cpcloud tests are failing

cpcloud added some commits Oct 4, 2018

@cpcloud cpcloud force-pushed the cpcloud:null-literal branch from 9a9d129 to a7ace3f Oct 10, 2018

@cpcloud cpcloud changed the title WIP: Make sure we cast when NULL is else in CASE expressions Make sure we cast when NULL is else in CASE expressions Oct 10, 2018

@kszucs

This comment has been minimized.

Copy link
Member

kszucs commented Oct 11, 2018

I've pinned clickhouse-driver to 0.0.15 until the following issue is going to be resolved: mymarilyn/clickhouse-driver#59

@cpcloud

This comment has been minimized.

Copy link
Member Author

cpcloud commented Oct 11, 2018

@kszucs thanks. I'll fix up the tests today.

@cpcloud

This comment has been minimized.

Copy link
Member Author

cpcloud commented Oct 12, 2018

Merging on green.

@cpcloud cpcloud closed this in ac38ada Oct 12, 2018

Refactoring automation moved this from To do to Done Oct 12, 2018

@cpcloud cpcloud deleted the cpcloud:null-literal branch Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.