Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MapD] Fixed where operator - Fixes #1623 #1653

Closed
wants to merge 7 commits into from

Conversation

Projects
2 participants
@xmnlab
Copy link
Collaborator

xmnlab commented Oct 12, 2018

This PR fixes #1623

xmnlab added some commits Oct 12, 2018

@xmnlab xmnlab changed the title Fixed where operator [MapD] Fixed where operator - Fixes #1623 Oct 12, 2018

@cpcloud cpcloud self-requested a review Oct 12, 2018

@cpcloud cpcloud self-assigned this Oct 12, 2018

@cpcloud cpcloud added bug mapd labels Oct 12, 2018

@cpcloud cpcloud added this to In progress in MapD via automation Oct 12, 2018

@cpcloud cpcloud added this to the Next Release milestone Oct 12, 2018

@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

xmnlab commented Oct 19, 2018

@cpcloud @kszucs

the conda build is failing for windows. do you have any idea about this error?

@cpcloud

This comment has been minimized.

Copy link
Member

cpcloud commented Oct 20, 2018

@xmnlab Yep, I've got #1660 up to address this.

@cpcloud

This comment has been minimized.

Copy link
Member

cpcloud commented Oct 20, 2018

@xmnlab Can you add a test here?

@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

xmnlab commented Oct 23, 2018

@cpcloud sure! I am working on that!

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #1653 into master will decrease coverage by 2.63%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1653      +/-   ##
==========================================
- Coverage   89.91%   87.28%   -2.64%     
==========================================
  Files         185      185              
  Lines       27207    27218      +11     
  Branches     2337     2337              
==========================================
- Hits        24463    23757     -706     
- Misses       2340     3054     +714     
- Partials      404      407       +3
Impacted Files Coverage Δ
ibis/mapd/operations.py 71.1% <100%> (+0.47%) ⬆️
ibis/mapd/tests/test_operations.py 95.23% <100%> (+1.9%) ⬆️
ibis/bigquery/tests/test_client.py 25.87% <0%> (-73.55%) ⬇️
ibis/bigquery/tests/test_compiler.py 39.89% <0%> (-60.11%) ⬇️
ibis/bigquery/udf/tests/test_udf_execute.py 28% <0%> (-54%) ⬇️
ibis/bigquery/client.py 42.91% <0%> (-52.37%) ⬇️
ibis/bigquery/compiler.py 58.82% <0%> (-38.61%) ⬇️
ibis/bigquery/tests/conftest.py 70.27% <0%> (-16.22%) ⬇️
ibis/bigquery/udf/api.py 80.48% <0%> (-14.64%) ⬇️
ibis/impala/compiler.py 91.04% <0%> (-5.75%) ⬇️
... and 10 more
@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

xmnlab commented Oct 24, 2018

it is ready for review!

@cpcloud

This comment has been minimized.

Copy link
Member

cpcloud commented Oct 26, 2018

LGTM. Thanks @xmnlab

MapD automation moved this from In progress to Reviewer approved Oct 26, 2018

@cpcloud cpcloud closed this in e4099a7 Oct 26, 2018

MapD automation moved this from Reviewer approved to Done Oct 26, 2018

@xmnlab xmnlab deleted the Quansight:mapd_where_op branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.