[MapD] Added crossjoin operator #1655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
bug
cpcloud
requested changes
Oct 12, 2018
ibis/mapd/compiler.py
Outdated
| @@ -150,6 +151,10 @@ def get_result(self): | |||
| fmt_preds = util.indent('USING ' + ', '.join(fmt_preds), | |||
| self.indent * 2) | |||
| buf.write(fmt_preds) | |||
| else: | |||
| buf.write( | |||
| util.indent('ON (TRUE)', self.indent * 2) | |||
There was a problem hiding this comment.
Does this need the parentheses?
There was a problem hiding this comment.
I think it is not necessary ... thanks!
ibis/mapd/operations.py
Outdated
| @@ -324,6 +324,13 @@ def _set_literal_format(translator, expr): | |||
| return '({})'.format(', '.join(formatted)) | |||
|
|
|||
|
|
|||
| def _cross_join(translator, expr): | |||
| args = expr.op().args | |||
| t1, t2 = args[:2] | |||
There was a problem hiding this comment.
I think these have names, like left and right. Can you use those if they exist?
There was a problem hiding this comment.
You're right! the names are left and right. thanks!
ibis/mapd/operations.py
Outdated
| def _cross_join(translator, expr): | ||
| args = expr.op().args | ||
| t1, t2 = args[:2] | ||
|
|
|
@cpcloud the conda build is failing for windows. do you have any idea about this error? |
cpcloud
added
feature
Codecov Report
@@ Coverage Diff @@
## master #1655 +/- ##
==========================================
- Coverage 89.94% 87.33% -2.62%
==========================================
Files 185 185
Lines 27209 27219 +10
Branches 2328 2337 +9
==========================================
- Hits 24474 23771 -703
- Misses 2335 3040 +705
- Partials 400 408 +8
|
|
same problem with mariadb on windows test py35 |
|
Thanks @xmnlab ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1621