Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC/CLN: Fix typo in docstring #1658

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@dsaxton
Copy link
Contributor

commented Oct 17, 2018

Fixes a very minor typo in the pandas/core.py docstring

Daniel Saxton
@codecov

This comment has been minimized.

Copy link

commented Oct 17, 2018

Codecov Report

Merging #1658 into master will decrease coverage by 2.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1658     +/-   ##
=========================================
- Coverage   89.88%   87.28%   -2.6%     
=========================================
  Files         185      185             
  Lines       27207    27207             
  Branches     2337     2337             
=========================================
- Hits        24455    23748    -707     
- Misses       2346     3052    +706     
- Partials      406      407      +1
Impacted Files Coverage Δ
ibis/pandas/core.py 100% <ø> (ø) ⬆️
ibis/bigquery/tests/test_client.py 25.87% <0%> (-73.55%) ⬇️
ibis/bigquery/tests/test_compiler.py 39.89% <0%> (-60.11%) ⬇️
ibis/bigquery/udf/tests/test_udf_execute.py 28% <0%> (-54%) ⬇️
ibis/bigquery/client.py 42.91% <0%> (-52.37%) ⬇️
ibis/bigquery/compiler.py 58.82% <0%> (-38.61%) ⬇️
ibis/bigquery/tests/conftest.py 70.27% <0%> (-16.22%) ⬇️
ibis/bigquery/udf/api.py 80.48% <0%> (-14.64%) ⬇️
ibis/impala/compiler.py 91.04% <0%> (-5.75%) ⬇️
ibis/tests/all/test_temporal.py 95.45% <0%> (-4.55%) ⬇️
... and 10 more
@kszucs

kszucs approved these changes Oct 18, 2018

Copy link
Member

left a comment

The build failure is unrelated. Thanks @dsaxton !

@cpcloud

This comment has been minimized.

Copy link
Member

commented Oct 20, 2018

Thanks @dsaxton, merging!

@cpcloud cpcloud closed this in fd32287 Oct 20, 2018

@dsaxton

This comment has been minimized.

Copy link
Contributor Author

commented Oct 20, 2018

@cpcloud @kszucs NP, glad to help!

@dsaxton dsaxton deleted the dsaxton:typo-fix branch Oct 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.