Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mapd] Fix MapD exception for toDateTime #1659

Closed
wants to merge 5 commits into from

Conversation

Projects
4 participants
@tonyfast
Copy link
Contributor

tonyfast commented Oct 17, 2018

This PR tries to resolve #1613 that demonstrates an error when using datetime columns.

@kszucs

This comment has been minimized.

Copy link
Member

kszucs commented Oct 18, 2018

@tonyfast looks like the build is failing

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 19, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@8feae7a). Click here to learn what that means.
The diff coverage is 70.58%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1659   +/-   ##
=========================================
  Coverage          ?   87.34%           
=========================================
  Files             ?      186           
  Lines             ?    27276           
  Branches          ?     2311           
=========================================
  Hits              ?    23824           
  Misses            ?     3046           
  Partials          ?      406
Impacted Files Coverage Δ
ibis/impala/tests/test_udf.py 21.71% <0%> (ø)
ibis/mapd/tests/test_operations.py 97.5% <100%> (ø)
ibis/mapd/operations.py 71.42% <71.42%> (ø)

@cpcloud cpcloud added this to In progress in MapD via automation Oct 20, 2018

@cpcloud cpcloud added the mapd label Oct 20, 2018

@cpcloud cpcloud added this to the Next Release milestone Oct 20, 2018

@cpcloud cpcloud changed the title Fix MapD exception for toDateTime [Mapd] Fix MapD exception for toDateTime Oct 20, 2018

@cpcloud cpcloud added the bug label Oct 20, 2018

MapD automation moved this from In progress to Needs review Oct 28, 2018

Show resolved Hide resolved ibis/mapd/operations.py Outdated
@cpcloud

This comment has been minimized.

Copy link
Member

cpcloud commented Oct 30, 2018

@tonyfast can you rebase?

@tonyfast

This comment has been minimized.

Copy link
Contributor Author

tonyfast commented Oct 31, 2018

Yes I'll have to get to this at the end of the week. Sorry for letting it sit.

@xmnlab

This comment has been minimized.

Copy link
Collaborator

xmnlab commented Dec 31, 2018

hey @tonyfast what is the status of this PR?

do you need any help with this PR?

tonyfast and others added some commits Oct 17, 2018

@kszucs kszucs force-pushed the tonyfast:master branch from 6722d7c to 42944dc Jan 31, 2019

@kszucs kszucs referenced this pull request Jan 31, 2019

Closed

Fix multiple CI issues #1696

resolved

@kszucs kszucs closed this in 71bdd23 Jan 31, 2019

MapD automation moved this from Needs review to Done Jan 31, 2019

@kszucs

This comment has been minimized.

Copy link
Member

kszucs commented Jan 31, 2019

Thanks @tonyfast and @xmnlab!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.