[Mapd] Fix MapD exception for toDateTime #1659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tonyfast looks like the build is failing |
Codecov Report
@@ Coverage Diff @@
## master #1659 +/- ##
=========================================
Coverage ? 87.34%
=========================================
Files ? 186
Lines ? 27276
Branches ? 2311
=========================================
Hits ? 23824
Misses ? 3046
Partials ? 406
|
cpcloud
changed the title
cpcloud
previously requested changes
Oct 28, 2018
|
@tonyfast can you rebase? |
|
Yes I'll have to get to this at the end of the week. Sorry for letting it sit. |
|
hey @tonyfast what is the status of this PR? do you need any help with this PR? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to resolve #1613 that demonstrates an error when using datetime columns.