Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Remove support for Python 2 #1670

Closed
wants to merge 75 commits into from

Conversation

Projects
2 participants
@cpcloud
Copy link
Member

commented Nov 2, 2018

No description provided.

@cpcloud cpcloud added this to the 1.0.0 milestone Nov 2, 2018

cpcloud added some commits Oct 30, 2018

Revert "Fix test"
This reverts commit 283949a.

@cpcloud cpcloud force-pushed the cpcloud:remove-py2 branch from 52fb511 to 9f51527 Nov 2, 2018

cpcloud added some commits Nov 2, 2018

kszucs and others added some commits Nov 4, 2018

Add signature to cast function
Co-Authored-By: cpcloud <cpcloud@gmail.com>
@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Nov 4, 2018

@kszucs If you want to do another pass, this is ready.

@cpcloud cpcloud added the refactoring label Nov 5, 2018

Show resolved Hide resolved ibis/expr/datatypes.py Outdated
Show resolved Hide resolved ibis/expr/datatypes.py Outdated
@kszucs

This comment has been minimized.

Copy link
Member

commented Nov 6, 2018

@cpcloud LGTM except the introduced BoundedInteger changes, see my comment above.

@cpcloud cpcloud force-pushed the cpcloud:remove-py2 branch from 0f93392 to c672d8a Nov 10, 2018

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Nov 10, 2018

Will merge when the azure build passes.

@kszucs

kszucs approved these changes Nov 10, 2018

Copy link
Member

left a comment

LGTM

@kszucs kszucs force-pushed the cpcloud:remove-py2 branch from c672d8a to 8f8d385 Nov 10, 2018

kszucs added some commits Nov 10, 2018

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Nov 10, 2018

@kszucs I think we can allow the setup and data load to fail on mysql and also disable the tests. That way we can see when the setup and load starts passing again. I'll do that in a follow up PR.

@cpcloud cpcloud closed this in c382cba Nov 10, 2018

Refactoring automation moved this from To do to Done Nov 10, 2018

@cpcloud cpcloud deleted the cpcloud:remove-py2 branch Nov 10, 2018

@kszucs

This comment has been minimized.

Copy link
Member

commented Nov 10, 2018

Ahh, I was just about to merge it :)
Created an issue for that: #1672

@kszucs

This comment has been minimized.

Copy link
Member

commented Nov 10, 2018

@cpcloud Shouldn't We document this somewhere? Or at least have an issue about documenting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.