ENH: Remove support for Python 2 #1670
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 283949a.
cpcloud
added
feature
Co-Authored-By: cpcloud <cpcloud@gmail.com>
Co-Authored-By: cpcloud <cpcloud@gmail.com>
|
@kszucs If you want to do another pass, this is ready. |
kszucs
reviewed
Nov 6, 2018
kszucs
reviewed
Nov 6, 2018
|
@cpcloud LGTM except the introduced |
|
Will merge when the azure build passes. |
|
@kszucs I think we can allow the setup and data load to fail on mysql and also disable the tests. That way we can see when the setup and load starts passing again. I'll do that in a follow up PR. |
|
Ahh, I was just about to merge it :) |
|
@cpcloud Shouldn't We document this somewhere? Or at least have an issue about documenting it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.