-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated mapd ci to v4.4.1 #1681
Conversation
|
waiting for tag v4.4.0 on mapd dockerhub |
Codecov Report
@@ Coverage Diff @@
## master #1681 +/- ##
=========================================
Coverage ? 86.97%
=========================================
Files ? 186
Lines ? 27257
Branches ? 2309
=========================================
Hits ? 23707
Misses ? 3147
Partials ? 403
|
|
is there a way to expose the log for mapd server? cc @andrewseidl |
|
@andrewseidl here you can see the log (on the last step: Show MapD Server log): https://circleci.com/gh/ibis-project/ibis/6263?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link let me know if I can help in any way related this log. |
|
Thanks! Could you try capping the amount of memory used by mapd_server for some of its buffers? In Line 1 in 1468b8c
Might need to play with the size a bit / could maybe bring it down lower to play nicer with the other services. Otherwise it seems like CircleCI might have slightly larger instances available, but we'd have to request access to them. Might be good to do that if there are a ton of different DBs running :) |
|
hey @andrewseidl it seems it works using your recommendations. thank you a lot! |
ci/requirements-dev-3.6.yml
Outdated
| @@ -37,3 +36,5 @@ dependencies: | |||
| - toolz | |||
| - xorg-libxpm | |||
| - xorg-libxrender | |||
| - pip: | |||
| - pymapd==0.6.0 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conda package is available.
.circleci/config.yml
Outdated
| @@ -75,6 +75,10 @@ test: &test | |||
| command: | | |||
| bash <(curl -s https://codecov.io/bash) \ | |||
| -f /tmp/ibis/test-reports/pytest-cov/coverage.xml | |||
| - run: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this, because We run multiple backends on the CI, and it can be confusing to only highlight the logs of mapd on failure.
|
@kszucs it is done for a new review! |
|
Thanks @xmnlab ! |
Updated mapd ci to v4.4.0