Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated mapd ci to v4.4.1 #1681

Closed
wants to merge 13 commits into from

Conversation

Projects
None yet
4 participants
@xmnlab
Copy link
Collaborator

commented Dec 28, 2018

Updated mapd ci to v4.4.0

@xmnlab xmnlab referenced this pull request Dec 28, 2018

Closed

mapd-ce-cpu image tag 4.4.0 #304

@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 28, 2018

waiting for tag v4.4.0 on mapd dockerhub

@kszucs kszucs added the mapd label Dec 31, 2018

@xmnlab xmnlab changed the title Updated mapd ci to v4.4.0 Updated mapd ci to v4.4.1 Jan 2, 2019

@codecov

This comment has been minimized.

Copy link

commented Jan 3, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@1468b8c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1681   +/-   ##
=========================================
  Coverage          ?   86.97%           
=========================================
  Files             ?      186           
  Lines             ?    27257           
  Branches          ?     2309           
=========================================
  Hits              ?    23707           
  Misses            ?     3147           
  Partials          ?      403
Impacted Files Coverage Δ
ibis/mapd/tests/conftest.py 56.41% <ø> (ø)

xmnlab added some commits Jan 3, 2019

@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 8, 2019

@cpcloud @kszucs

is there a way to expose the log for mapd server?

cc @andrewseidl

@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 9, 2019

@andrewseidl here you can see the log (on the last step: Show MapD Server log): https://circleci.com/gh/ibis-project/ibis/6263?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

let me know if I can help in any way related this log.

@andrewseidl

This comment has been minimized.

Copy link

commented Jan 9, 2019

Thanks!

Could you try capping the amount of memory used by mapd_server for some of its buffers? In

enable-watchdog = false
add a new line with e.g.:

cpu-buffer-mem-bytes = 1000000000

Might need to play with the size a bit / could maybe bring it down lower to play nicer with the other services.

Otherwise it seems like CircleCI might have slightly larger instances available, but we'd have to request access to them. Might be good to do that if there are a ton of different DBs running :)

@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 9, 2019

hey @andrewseidl it seems it works using your recommendations. thank you a lot!

@cpcloud @kszucs that is done for review!

@@ -37,3 +36,5 @@ dependencies:
- toolz
- xorg-libxpm
- xorg-libxrender
- pip:
- pymapd==0.6.0

This comment has been minimized.

Copy link
@kszucs

kszucs Jan 9, 2019

Member

The conda package is available.

@@ -75,6 +75,10 @@ test: &test
command: |
bash <(curl -s https://codecov.io/bash) \
-f /tmp/ibis/test-reports/pytest-cov/coverage.xml
- run:

This comment has been minimized.

Copy link
@kszucs

kszucs Jan 9, 2019

Member

Please remove this, because We run multiple backends on the CI, and it can be confusing to only highlight the logs of mapd on failure.

xmnlab added some commits Jan 9, 2019

@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 10, 2019

@kszucs it is done for a new review!

@cpcloud

This comment has been minimized.

Copy link
Member

commented Jan 12, 2019

Thanks @xmnlab !

@cpcloud cpcloud closed this in bf9f7e4 Jan 12, 2019

@xmnlab xmnlab deleted the Quansight:update_mapd_ci_440 branch Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.