Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pre commit hook #1685

Closed
wants to merge 6 commits into from
Closed

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Dec 31, 2018

No description provided.

@codecov
Copy link

codecov bot commented Dec 31, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@1468b8c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1685   +/-   ##
=========================================
  Coverage          ?   87.41%           
=========================================
  Files             ?      186           
  Lines             ?    27265           
  Branches          ?     2310           
=========================================
  Hits              ?    23834           
  Misses            ?     3025           
  Partials          ?      406

@xmnlab
Copy link
Contributor Author

xmnlab commented Jan 2, 2019

@cpcloud @kszucs I think it is done for review :)

@xmnlab
Copy link
Contributor Author

xmnlab commented Jan 8, 2019

@cpcloud @kszucs any feedback about this PR?

@kszucs
Copy link
Member

kszucs commented Jan 9, 2019

@xmnlab it looks good to me.
Could You please mention it in the developer documentation?

@cpcloud should We merge developer.rst and contributing.rst?

@xmnlab
Copy link
Contributor Author

xmnlab commented Jan 9, 2019

@kszucs sure! I will do it now. thanks!

@xmnlab
Copy link
Contributor Author

xmnlab commented Jan 10, 2019

@kszucs it is done for a new review!

@cpcloud
Copy link
Member

cpcloud commented Jan 12, 2019

LGTM, merging.

@cpcloud cpcloud closed this in a6b1957 Jan 12, 2019
@xmnlab xmnlab deleted the pre-commit branch January 14, 2019 02:16
@xmnlab xmnlab mentioned this pull request Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants