Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting started mapd mysql pandas #1686

Closed

Conversation

Projects
None yet
3 participants
@xmnlab
Copy link
Collaborator

commented Jan 2, 2019

Fixes #1663

@codecov

This comment has been minimized.

Copy link

commented Jan 2, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@1468b8c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1686   +/-   ##
=========================================
  Coverage          ?   87.44%           
=========================================
  Files             ?      186           
  Lines             ?    27265           
  Branches          ?     2310           
=========================================
  Hits              ?    23842           
  Misses            ?     3019           
  Partials          ?      404
@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 3, 2019

@cpcloud @kszucs it seems it is done for review :)

@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 8, 2019

@cpcloud @kszucs any feedback about this PR?

@kszucs

kszucs approved these changes Jan 9, 2019

@cpcloud

cpcloud approved these changes Jan 9, 2019

@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 9, 2019

could this be merged?

@cpcloud cpcloud closed this in 7b1e6c2 Jan 12, 2019

@cpcloud

This comment has been minimized.

Copy link
Member

commented Jan 12, 2019

Thanks @xmnlab !

@xmnlab xmnlab deleted the Quansight:getting-started-mapd-mysql-pandas branch Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.