-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed from pygdf to cudf #1694
Conversation
|
waiting for #1696 |
|
cc @niviksha |
|
logs: windowstest py37 |
|
That seems sporious... I'll restart it. |
|
Ok thanks for the advice! In another project we were losting code using rebase. Do you have any tip or recommendation for using rebase to avoid this problem? |
|
@xmnlab Well, not really. I'm aware of the disadvantages of a force push, but We both ibis and apache arrow prefer rebase. Need to be careful :) |
|
I will be careful! thanks @kszucs! it seems pipelines is working! thanks! could you review this PR? |
Codecov Report
@@ Coverage Diff @@
## master #1694 +/- ##
=========================================
Coverage ? 87.33%
=========================================
Files ? 186
Lines ? 27258
Branches ? 2310
=========================================
Hits ? 23807
Misses ? 3046
Partials ? 405
|
Codecov Report
@@ Coverage Diff @@
## master #1694 +/- ##
==========================================
- Coverage 89.99% 87.34% -2.65%
==========================================
Files 186 186
Lines 27300 27300
Branches 2311 2311
==========================================
- Hits 24569 23846 -723
- Misses 2330 3048 +718
- Partials 401 406 +5
|
|
Rebased |
|
thanks @kszucs ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #1693