Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed from pygdf to cudf #1694

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@xmnlab
Copy link
Collaborator

commented Jan 28, 2019

Fixes #1693

@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 28, 2019

waiting for #1696

@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 28, 2019

@kszucs kszucs force-pushed the Quansight:pygdf2cudf branch from dac4aae to 3ef5d80 Jan 31, 2019

@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 31, 2019

logs:

windowstest py37


2019-01-31T16:17:51.1349414Z ##[section]Starting: Load PostgreSQL data
2019-01-31T16:17:51.1449954Z ==============================================================================
2019-01-31T16:17:51.1450171Z Task         : Command Line
2019-01-31T16:17:51.1450227Z Description  : Run a command line script using cmd.exe on Windows and bash on macOS and Linux.
2019-01-31T16:17:51.1450263Z Version      : 2.146.1
2019-01-31T16:17:51.1450311Z Author       : Microsoft Corporation
2019-01-31T16:17:51.1450369Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkID=613735)
2019-01-31T16:17:51.1450406Z ==============================================================================
2019-01-31T16:17:52.3496590Z Generating script.
2019-01-31T16:17:52.3496670Z Script contents:
2019-01-31T16:17:52.3496716Z python ci/datamgr.py postgres --psql-path="C:/Program Files/PostgreSQL/10/bin/psql.exe"
2019-01-31T16:17:52.3496952Z ##[command]"C:\Windows\system32\cmd.exe" /D /E:ON /V:OFF /S /C "CALL "D:\a\_temp\d8f6df15-a0eb-4349-af3e-8595cb3e7254.cmd""
2019-01-31T16:17:53.0834184Z Traceback (most recent call last):
2019-01-31T16:17:53.0834344Z   File "ci/datamgr.py", line 484, in <module>
2019-01-31T16:17:53.0834428Z     cli(auto_envvar_prefix='IBIS_TEST')
2019-01-31T16:17:53.0834490Z   File "C:\Users\VssAdministrator\.conda\envs\ibis_3.7\lib\site-packages\click\core.py", line 764, in __call__
2019-01-31T16:17:53.0834597Z     return self.main(*args, **kwargs)
2019-01-31T16:17:53.0834659Z   File "C:\Users\VssAdministrator\.conda\envs\ibis_3.7\lib\site-packages\click\core.py", line 717, in main
2019-01-31T16:17:53.0834712Z     rv = self.invoke(ctx)
2019-01-31T16:17:53.0834791Z   File "C:\Users\VssAdministrator\.conda\envs\ibis_3.7\lib\site-packages\click\core.py", line 1137, in invoke
2019-01-31T16:17:53.0834849Z     return _process_result(sub_ctx.command.invoke(sub_ctx))
2019-01-31T16:17:53.0834910Z   File "C:\Users\VssAdministrator\.conda\envs\ibis_3.7\lib\site-packages\click\core.py", line 956, in invoke
2019-01-31T16:17:53.0834996Z     return ctx.invoke(self.callback, **ctx.params)
2019-01-31T16:17:53.0835059Z   File "C:\Users\VssAdministrator\.conda\envs\ibis_3.7\lib\site-packages\click\core.py", line 555, in invoke
2019-01-31T16:17:53.0835113Z     return callback(*args, **kwargs)
2019-01-31T16:17:53.0835184Z   File "ci/datamgr.py", line 180, in postgres
2019-01-31T16:17:53.0835397Z     isolation_level='AUTOCOMMIT')
2019-01-31T16:17:53.0835620Z   File "ci/datamgr.py", line 47, in init_database
2019-01-31T16:17:53.0835666Z     recreate_database(driver, new_params, **kwargs)
2019-01-31T16:17:53.0835728Z   File "ci/datamgr.py", line 35, in recreate_database
2019-01-31T16:17:53.0835769Z     engine = sa.create_engine(url, **kwargs)
2019-01-31T16:17:53.0835820Z   File "C:\Users\VssAdministrator\.conda\envs\ibis_3.7\lib\site-packages\sqlalchemy\engine\__init__.py", line 431, in create_engine
2019-01-31T16:17:53.0835887Z     return strategy.create(*args, **kwargs)
2019-01-31T16:17:53.0835940Z   File "C:\Users\VssAdministrator\.conda\envs\ibis_3.7\lib\site-packages\sqlalchemy\engine\strategies.py", line 87, in create
2019-01-31T16:17:53.0836011Z     dbapi = dialect_cls.dbapi(**dbapi_args)
2019-01-31T16:17:53.0836064Z   File "C:\Users\VssAdministrator\.conda\envs\ibis_3.7\lib\site-packages\sqlalchemy\dialects\postgresql\psycopg2.py", line 599, in dbapi
2019-01-31T16:17:53.0836108Z     import psycopg2
2019-01-31T16:17:53.0836180Z   File "C:\Users\VssAdministrator\.conda\envs\ibis_3.7\lib\site-packages\psycopg2\__init__.py", line 50, in <module>
2019-01-31T16:17:53.0836229Z     from psycopg2._psycopg import (                     # noqa
2019-01-31T16:17:53.0836275Z ImportError: DLL load failed: The specified module could not be found.
2019-01-31T16:17:53.2853967Z ##[error]Cmd.exe exited with code '1'.
2019-01-31T16:17:53.3208928Z ##[section]Finishing: Load PostgreSQL data

@kszucs

This comment has been minimized.

Copy link
Member

commented Jan 31, 2019

That seems sporious... I'll restart it.
Please use rebase instead of merge, that makes it easier to review and maintain a flat history.

@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 31, 2019

Ok thanks for the advice! In another project we were losting code using rebase. Do you have any tip or recommendation for using rebase to avoid this problem?

@kszucs

This comment has been minimized.

Copy link
Member

commented Jan 31, 2019

@xmnlab Well, not really. I'm aware of the disadvantages of a force push, but We both ibis and apache arrow prefer rebase. Need to be careful :)

@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 31, 2019

I will be careful! thanks @kszucs!

it seems pipelines is working! thanks! could you review this PR?

@codecov

This comment has been minimized.

Copy link

commented Feb 4, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@8feae7a). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1694   +/-   ##
=========================================
  Coverage          ?   87.33%           
=========================================
  Files             ?      186           
  Lines             ?    27258           
  Branches          ?     2310           
=========================================
  Hits              ?    23807           
  Misses            ?     3046           
  Partials          ?      405
Impacted Files Coverage Δ
ibis/mapd/client.py 50.17% <ø> (ø)
ibis/impala/tests/test_udf.py 21.71% <0%> (ø)
@codecov

This comment has been minimized.

Copy link

commented Feb 4, 2019

Codecov Report

Merging #1694 into master will decrease coverage by 2.64%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1694      +/-   ##
==========================================
- Coverage   89.99%   87.34%   -2.65%     
==========================================
  Files         186      186              
  Lines       27300    27300              
  Branches     2311     2311              
==========================================
- Hits        24569    23846     -723     
- Misses       2330     3048     +718     
- Partials      401      406       +5
Impacted Files Coverage Δ
ibis/mapd/client.py 50.85% <100%> (ø) ⬆️
ibis/bigquery/tests/test_client.py 25.87% <0%> (-73.55%) ⬇️
ibis/bigquery/tests/test_compiler.py 39.57% <0%> (-60.43%) ⬇️
ibis/bigquery/udf/tests/test_udf_execute.py 28.71% <0%> (-53.47%) ⬇️
ibis/bigquery/client.py 42.67% <0%> (-52.59%) ⬇️
ibis/bigquery/compiler.py 58.67% <0%> (-38.75%) ⬇️
ibis/bigquery/tests/conftest.py 70.27% <0%> (-16.22%) ⬇️
ibis/bigquery/udf/api.py 80.48% <0%> (-14.64%) ⬇️
ibis/impala/compiler.py 91.04% <0%> (-5.75%) ⬇️
ibis/tests/all/test_temporal.py 95.45% <0%> (-4.55%) ⬇️
... and 10 more

@xmnlab xmnlab force-pushed the Quansight:pygdf2cudf branch from cabf728 to 4b7a3dc Feb 9, 2019

@kszucs kszucs force-pushed the Quansight:pygdf2cudf branch from 4b7a3dc to cf7d79b Feb 21, 2019

@kszucs

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

Rebased

@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 21, 2019

thanks @kszucs !

@kszucs

kszucs approved these changes Feb 21, 2019

Copy link
Member

left a comment

LGTM

@kszucs kszucs closed this in bd01247 Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.