Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: error in visualizing a graph, with a selection after a table join #1705

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@jreback
Copy link
Contributor

commented Feb 7, 2019

No description provided.

@jreback jreback added the bug label Feb 7, 2019

@jreback

This comment has been minimized.

Copy link
Contributor Author

commented Feb 7, 2019

@cpcloud as discussed

@codecov

This comment has been minimized.

Copy link

commented Feb 7, 2019

Codecov Report

Merging #1705 into master will decrease coverage by 2.61%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1705      +/-   ##
==========================================
- Coverage   89.95%   87.34%   -2.62%     
==========================================
  Files         186      186              
  Lines       27276    27285       +9     
  Branches     2311     2311              
==========================================
- Hits        24537    23831     -706     
- Misses       2336     3048     +712     
- Partials      403      406       +3
Impacted Files Coverage Δ
ibis/expr/tests/test_visualize.py 100% <100%> (ø) ⬆️
ibis/expr/visualize.py 87.34% <100%> (ø) ⬆️
ibis/bigquery/tests/test_client.py 25.87% <0%> (-73.55%) ⬇️
ibis/bigquery/tests/test_compiler.py 39.57% <0%> (-60.43%) ⬇️
ibis/bigquery/udf/tests/test_udf_execute.py 28.71% <0%> (-53.47%) ⬇️
ibis/bigquery/client.py 42.67% <0%> (-52.59%) ⬇️
ibis/bigquery/compiler.py 58.67% <0%> (-38.75%) ⬇️
ibis/bigquery/tests/conftest.py 70.27% <0%> (-16.22%) ⬇️
ibis/bigquery/udf/api.py 80.48% <0%> (-14.64%) ⬇️
ibis/impala/compiler.py 91.04% <0%> (-5.75%) ⬇️
... and 9 more
1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Feb 7, 2019

Codecov Report

Merging #1705 into master will decrease coverage by 2.61%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1705      +/-   ##
==========================================
- Coverage   89.95%   87.34%   -2.62%     
==========================================
  Files         186      186              
  Lines       27276    27285       +9     
  Branches     2311     2311              
==========================================
- Hits        24537    23831     -706     
- Misses       2336     3048     +712     
- Partials      403      406       +3
Impacted Files Coverage Δ
ibis/expr/tests/test_visualize.py 100% <100%> (ø) ⬆️
ibis/expr/visualize.py 87.34% <100%> (ø) ⬆️
ibis/bigquery/tests/test_client.py 25.87% <0%> (-73.55%) ⬇️
ibis/bigquery/tests/test_compiler.py 39.57% <0%> (-60.43%) ⬇️
ibis/bigquery/udf/tests/test_udf_execute.py 28.71% <0%> (-53.47%) ⬇️
ibis/bigquery/client.py 42.67% <0%> (-52.59%) ⬇️
ibis/bigquery/compiler.py 58.67% <0%> (-38.75%) ⬇️
ibis/bigquery/tests/conftest.py 70.27% <0%> (-16.22%) ⬇️
ibis/bigquery/udf/api.py 80.48% <0%> (-14.64%) ⬇️
ibis/impala/compiler.py 91.04% <0%> (-5.75%) ⬇️
... and 9 more
@kszucs

kszucs approved these changes Feb 21, 2019

Copy link
Member

left a comment

LGTM

@kszucs kszucs closed this in d3cc7b0 Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.