Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove long-deprecated code and clean up warnings created by ibis #1714

Closed
wants to merge 49 commits into from

Conversation

Projects
2 participants
@cpcloud
Copy link
Member

commented Mar 10, 2019

No description provided.

@cpcloud cpcloud requested a review from kszucs Mar 10, 2019

@kszucs

kszucs approved these changes Mar 10, 2019

Copy link
Member

left a comment

LGTM

@cpcloud cpcloud added this to the 1.0.0 milestone Mar 10, 2019

@cpcloud cpcloud added this to To do in Refactoring via automation Mar 10, 2019

@cpcloud cpcloud added the refactoring label Mar 10, 2019

@cpcloud cpcloud referenced this pull request Mar 10, 2019

Merged

Update pymapd #26

4 of 4 tasks complete
@kszucs

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

@cpcloud Is it ready for a new pass?

@kszucs

kszucs approved these changes Mar 10, 2019

cpcloud added some commits Mar 3, 2019

cpcloud and others added some commits Mar 10, 2019

@cpcloud cpcloud force-pushed the cpcloud:address-warnings branch from c80a8bf to 3b8771f Mar 10, 2019

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2019

@kszucs Once this is all green, I'll merge.

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2019

Actually, looks like there are a few more stragglers.

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2019

Ok, now we should be good to go on green!

@cpcloud cpcloud closed this in 8d488a4 Mar 10, 2019

Refactoring automation moved this from To do to Done Mar 10, 2019

@cpcloud cpcloud deleted the cpcloud:address-warnings branch Mar 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.