Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove long-deprecated code and clean up warnings created by ibis #1714

Closed
wants to merge 49 commits into from
Closed

Remove long-deprecated code and clean up warnings created by ibis #1714

wants to merge 49 commits into from

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Mar 10, 2019

No description provided.

@cpcloud cpcloud requested a review from kszucs March 10, 2019 00:09
kszucs
kszucs approved these changes Mar 10, 2019
View reviewed changes
Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpcloud cpcloud added this to the 1.0.0 milestone Mar 10, 2019
@cpcloud cpcloud added the refactor Issues or PRs related to refactoring the codebase label Mar 10, 2019
@cpcloud cpcloud mentioned this pull request Mar 10, 2019
Merged
4 tasks
@kszucs
Copy link
Member

kszucs commented Mar 10, 2019

@cpcloud Is it ready for a new pass?

@cpcloud
Remove add_column
274d8aa
@cpcloud
Use collections.abc for ABCs
96581ff
@cpcloud
Address pytest raises message parameter warning
7da184e
@cpcloud
Use tz_localize instead of tz argument
068cff5
@cpcloud
Binary has been renamed to LargeBinary in SQLAlchemy
9c49630
@cpcloud
Use raw to preserve behavior in apply
888dfb5
@cpcloud
Move all unit usages to interval
ffd3371
@cpcloud
Add PYTEST_OPTIONS to makefile
50febc1
@cpcloud
Fix pytest test
ae700bd
@cpcloud
Remove usage of ix
a89970b
@cpcloud
Put raw in the correct place
f9ed0b3
@cpcloud
Remove timedelta api
c0256fe
@cpcloud
Remove internal usage of timedelta api
635a989
@cpcloud
Ignore bytecode related files and directories
2d38bac
@cpcloud
ix is inclusive apparently
8787f2b
@cpcloud
Fix raw passing
8e43237
@cpcloud
Fix usage of intervals and tz
330c60b
@cpcloud
SQLAlchemy warning
f42b713
@cpcloud
More raw fixes
d363749
@cpcloud
Fix numpy warning
6360bd3
@cpcloud
Pass skipna=True to infer_dtype from pandas
9b0cb94
@cpcloud
Constrain pandas to make sure we have the skipna argument to infer_dtype
cee5496
@cpcloud
Fix warning
8e05336
cpcloud and others added 23 commits March 10, 2019 18:01
@cpcloud
Address bigquery date offset arithmetic warning in test
9f683ea
@cpcloud
Fix docstring
6fb7808
@cpcloud
Address race condition in tear down
d073e6f
@cpcloud
Remove usage of named intervals
1a0a5ab
@cpcloud
Map plural to singular
200c495
@cpcloud
Use the right variable
51e5b74
@cpcloud
Simplify make test
cc50c96
@cpcloud
Pass session explicitly
533100b
@cpcloud
Docstring cleanup
3fb9d42
@cpcloud
Add session kwarg docstring
b3c0a8f
@cpcloud
Fix importing and skipping
f165e29
@cpcloud
Make it easy to start up a specific service, e.g., if it goes down
db6e0f3
@cpcloud
Remove add_column from api.rst
5436d22
@cpcloud
Refer to named argument rather than position
78c2577
@cpcloud
Clean up manual tempfile creation
737dfbb
@cpcloud
Formatting
e0af86c
@cpcloud
Fix interval usage in docs
6e624bf
@cpcloud
Remove gz usage in ci/setup_docker_volume.sh
557f010
@cpcloud
Allow restart to use ${SERVICES}
f5d8d2e
@kszucs @cpcloud
fix deprecations in notebook
56a3c81
@cpcloud
Remove services
7a2d918
@cpcloud
Fixup docstring
d7803ac
@cpcloud
Fix interval usage
3b8771f
@cpcloud
Copy link
Member Author

cpcloud commented Mar 10, 2019

@kszucs Once this is all green, I'll merge.

@cpcloud
Copy link
Member Author

cpcloud commented Mar 10, 2019

Actually, looks like there are a few more stragglers.

@cpcloud
Copy link
Member Author

cpcloud commented Mar 10, 2019

Ok, now we should be good to go on green!

@cpcloud cpcloud closed this in 8d488a4 Mar 10, 2019
@cpcloud cpcloud deleted the address-warnings branch March 10, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kszucs kszucs kszucs approved these changes

Assignees
No one assigned
Labels
refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @kszucs