Implement default handler for multiple client pre_execute #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
reviewed
Mar 14, 2019
| @@ -46,6 +48,15 @@ def pre_execute_default(node, *clients, **kwargs): | |||
| return {} | |||
|
|
|||
|
|
|||
| # Merge the results of all client pre-execution with scope | |||
| @pre_execute.register(ops.Node, [ibis.client.Client]) | |||
There was a problem hiding this comment.
Should this be:
pre_execute.register(ops.Node, ibis.client.Client, [ibis.client.Client])
Or are you intentionally matching 0 clients as well?
There was a problem hiding this comment.
ah, no, i didn't realize it might match 0 clients. what does the function signature look like for that dispatch registration?
There was a problem hiding this comment.
function signature looks like pre_execute(op, client, *clients, **kwargs)
|
LGTM. Will merge later today. |
|
Thanks @toryhaavik! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.