Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement bigquery auth using pydata_google_auth #1728

Closed
wants to merge 7 commits into from

Conversation

Projects
2 participants
@cpcloud
Copy link
Member

commented Mar 14, 2019

Also allow project_id and dataset_id to be optional

Closes #1583

cpcloud added some commits Mar 14, 2019

@cpcloud cpcloud added this to the 1.0.0 milestone Mar 14, 2019

@cpcloud cpcloud added this to To do in BigQuery via automation Mar 14, 2019

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

@tswast Can you review this when you get a chance?

Show resolved Hide resolved ibis/bigquery/api.py Outdated
@tswast

tswast approved these changes Mar 14, 2019

Copy link
Contributor

left a comment

Auth changes LGTM.

You could potentially allow passing in additional scopes in case folks want to do federated queries to Google Sheets, but they can always call pydata_google_auth themselves and pass in the scopes they need in that case. I think defaulting to just the BigQuery scope is the right choice.

@tswast

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

Looking at this, I'm realizing I should pull some of the auth how-to stuff from pandas-gbq over to the pydata-google-auth docs so that it can be a central resource for Ibis and pandas to link to.

I've filed pydata/pydata-google-auth#19 to track that. I can follow-up with a PR to the Ibis docs once I get that in place.

Show resolved Hide resolved ibis/bigquery/api.py

cpcloud added some commits Mar 14, 2019

@tswast

tswast approved these changes Mar 14, 2019

@cpcloud cpcloud closed this in eb3c98c Mar 17, 2019

BigQuery automation moved this from To do to Done Mar 17, 2019

@cpcloud cpcloud deleted the cpcloud:gh-1583 branch Mar 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.