BUG: Fix a bug in TableExpr.drop #1732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kszucs
reviewed
Mar 18, 2019
kszucs
reviewed
Mar 18, 2019
kszucs
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the drop method wasn't using
__getitem__toproject.
__getitem__calls a functionbind_exprthat binds a table to the projectedexpression.
As a follow-up we should bring this behavior to projection to avoid issues like
this in the future.
One issue with adding a call to
ir.bind_expr(self, what)to theprojectionmethod is that it breaks some fusion optimizations.I think that as part of the the post 1.0.0 follow-up work we need to disable and remove all optimizations until we can restructure the compiler flow to separate optimization from expression construction.