Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MapD] Cast to float #1737

Closed
wants to merge 5 commits into from

Conversation

Projects
2 participants
@xmnlab
Copy link
Collaborator

commented Mar 19, 2019

Resolves #1682

@cpcloud

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

@xmnlab I've put up #1738 to address the BigQuery auth issues.

@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 19, 2019

awesome! thank you so much @cpcloud !

@cpcloud

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

@xmnlab Can you rebase?

@cpcloud cpcloud added this to the 1.0.0 milestone Mar 20, 2019

@cpcloud cpcloud added this to In progress in MapD via automation Mar 20, 2019

@cpcloud cpcloud added the mapd label Mar 20, 2019

@xmnlab xmnlab changed the title Resolves #1682 [MapD] Cast to float Mar 20, 2019

@xmnlab xmnlab force-pushed the Quansight:float_to_cast branch from 67447f9 to 34c14c9 Mar 20, 2019

@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 20, 2019

rebase done!

@cpcloud

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

It looks like I didn't fix the auth stuff. I know why, putting up a PR.

@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 20, 2019

@cpcloud thanks!

@cpcloud

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

Ah actually there appear to be a few cases where I call ibis.bigquery.connect without checking for credentials first.

@cpcloud

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

@xmnlab Can you cherry-pick from #1741 and see if that fixes the CI for you?

@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 20, 2019

@cpcloud awesome! thanks I will do it!

@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 20, 2019

I am trying your changes on #1683

cpcloud and others added some commits Mar 20, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 21, 2019

Codecov Report

Merging #1737 into master will decrease coverage by 1.92%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1737      +/-   ##
==========================================
- Coverage   87.34%   85.41%   -1.93%     
==========================================
  Files          80       80              
  Lines       14934    14934              
  Branches     1919     1919              
==========================================
- Hits        13044    12756     -288     
- Misses       1544     1834     +290     
+ Partials      346      344       -2
Impacted Files Coverage Δ
ibis/mapd/client.py 51.02% <ø> (ø) ⬆️
ibis/bigquery/client.py 41.1% <0%> (-53.39%) ⬇️
ibis/bigquery/compiler.py 58.67% <0%> (-38.75%) ⬇️
ibis/bigquery/udf/api.py 80.48% <0%> (-14.64%) ⬇️
ibis/bigquery/api.py 63.33% <0%> (-10.01%) ⬇️
ibis/impala/compiler.py 91.04% <0%> (-5.75%) ⬇️
ibis/pandas/client.py 86.54% <0%> (-3.51%) ⬇️
ibis/expr/schema.py 89.77% <0%> (-1.14%) ⬇️
ibis/expr/window.py 86.77% <0%> (-0.83%) ⬇️
ibis/expr/api.py 93.55% <0%> (-0.4%) ⬇️
... and 3 more
1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Mar 21, 2019

Codecov Report

Merging #1737 into master will decrease coverage by 1.92%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1737      +/-   ##
==========================================
- Coverage   87.34%   85.41%   -1.93%     
==========================================
  Files          80       80              
  Lines       14934    14934              
  Branches     1919     1919              
==========================================
- Hits        13044    12756     -288     
- Misses       1544     1834     +290     
+ Partials      346      344       -2
Impacted Files Coverage Δ
ibis/mapd/client.py 51.02% <ø> (ø) ⬆️
ibis/bigquery/client.py 41.1% <0%> (-53.39%) ⬇️
ibis/bigquery/compiler.py 58.67% <0%> (-38.75%) ⬇️
ibis/bigquery/udf/api.py 80.48% <0%> (-14.64%) ⬇️
ibis/bigquery/api.py 63.33% <0%> (-10.01%) ⬇️
ibis/impala/compiler.py 91.04% <0%> (-5.75%) ⬇️
ibis/pandas/client.py 86.54% <0%> (-3.51%) ⬇️
ibis/expr/schema.py 89.77% <0%> (-1.14%) ⬇️
ibis/expr/window.py 86.77% <0%> (-0.83%) ⬇️
ibis/expr/api.py 93.55% <0%> (-0.4%) ⬇️
... and 3 more
@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 21, 2019

@cpcloud @kszucs it seems it is done for review :)

@cpcloud

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

@xmnlab LGTM! Merging.

@cpcloud cpcloud self-assigned this Mar 21, 2019

MapD automation moved this from In progress to Reviewer approved Mar 21, 2019

@cpcloud cpcloud closed this in 4bba5ea Mar 21, 2019

MapD automation moved this from Reviewer approved to Done Mar 21, 2019

@xmnlab xmnlab deleted the Quansight:float_to_cast branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.