Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/TST: Fix skipping for new auth flow #1738

Closed
wants to merge 1 commit into from

Conversation

Projects
2 participants
@cpcloud
Copy link
Member

cpcloud commented Mar 19, 2019

No description provided.

@cpcloud cpcloud referenced this pull request Mar 19, 2019

Closed

[MapD] Cast to float #1737

@cpcloud cpcloud added this to To do in BigQuery via automation Mar 19, 2019

@cpcloud cpcloud added this to the 1.0.0 milestone Mar 19, 2019

@cpcloud

This comment has been minimized.

Copy link
Member Author

cpcloud commented Mar 19, 2019

Per #1739 I'm going to disable the window 3.7 build for now.

@cpcloud

This comment has been minimized.

Copy link
Member Author

cpcloud commented Mar 19, 2019

First trying one more thing before disabling..

@xmnlab

This comment has been minimized.

Copy link
Collaborator

xmnlab commented Mar 19, 2019

hey @cpcloud maybe for azure configuration would be good to update the structure. createCustomEnvironment is deprecated now. I changed that in this PR: https://github.com/ibis-project/ibis/pull/1710/files#diff-fec826feae04e51c0d94076385408bdcR13

@cpcloud

This comment has been minimized.

Copy link
Member Author

cpcloud commented Mar 19, 2019

Ok, I will take a look at bit later. Thanks @xmnlab!

@xmnlab

This comment has been minimized.

Copy link
Collaborator

xmnlab commented Mar 19, 2019

great! let me know if I can help in any way 👍

@cpcloud

This comment has been minimized.

Copy link
Member Author

cpcloud commented Mar 20, 2019

@xmnlab It looks like this may have worked! I'll check back later today and merge on green so we can close out some of the remaining PRs for 1.0.0.

@cpcloud cpcloud force-pushed the cpcloud:fix-bigquery-auth-ci branch 2 times, most recently from d472846 to 7bde569 Mar 20, 2019

@cpcloud

This comment has been minimized.

Copy link
Member Author

cpcloud commented Mar 20, 2019

@xmnlab I cherry picked most of your changes from #1710, hope you don't mind!

CI: Skip bigquery tests if we cannot connect
Also fix failing Python 3.7 builds

@cpcloud cpcloud force-pushed the cpcloud:fix-bigquery-auth-ci branch from 7bde569 to c1e6a37 Mar 20, 2019

@xmnlab

This comment has been minimized.

Copy link
Collaborator

xmnlab commented Mar 20, 2019

@cpcloud awesome!

@cpcloud cpcloud closed this in 9106cec Mar 20, 2019

BigQuery automation moved this from To do to Done Mar 20, 2019

@cpcloud cpcloud deleted the cpcloud:fix-bigquery-auth-ci branch Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.