Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/TST: Fix skipping for new auth flow #1738

Closed
wants to merge 1 commit into from

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Mar 19, 2019

No description provided.

@cpcloud cpcloud mentioned this pull request Mar 19, 2019
@cpcloud cpcloud added bug Incorrect behavior inside of ibis tests Issues or PRs related to tests ci Continuous Integration issues or PRs bigquery labels Mar 19, 2019
@cpcloud cpcloud added this to the 1.0.0 milestone Mar 19, 2019
@cpcloud
Copy link
Member Author

cpcloud commented Mar 19, 2019

Per #1739 I'm going to disable the window 3.7 build for now.

@cpcloud
Copy link
Member Author

cpcloud commented Mar 19, 2019

First trying one more thing before disabling..

@xmnlab
Copy link
Contributor

xmnlab commented Mar 19, 2019

hey @cpcloud maybe for azure configuration would be good to update the structure. createCustomEnvironment is deprecated now. I changed that in this PR: https://github.com/ibis-project/ibis/pull/1710/files#diff-fec826feae04e51c0d94076385408bdcR13

@cpcloud
Copy link
Member Author

cpcloud commented Mar 19, 2019

Ok, I will take a look at bit later. Thanks @xmnlab!

@xmnlab
Copy link
Contributor

xmnlab commented Mar 19, 2019

great! let me know if I can help in any way 👍

@cpcloud
Copy link
Member Author

cpcloud commented Mar 20, 2019

@xmnlab It looks like this may have worked! I'll check back later today and merge on green so we can close out some of the remaining PRs for 1.0.0.

@cpcloud cpcloud force-pushed the fix-bigquery-auth-ci branch 2 times, most recently from d472846 to 7bde569 Compare March 20, 2019 13:00
@cpcloud
Copy link
Member Author

cpcloud commented Mar 20, 2019

@xmnlab I cherry picked most of your changes from #1710, hope you don't mind!

Also fix failing Python 3.7 builds
@xmnlab
Copy link
Contributor

xmnlab commented Mar 20, 2019

@cpcloud awesome!

@cpcloud cpcloud closed this in 9106cec Mar 20, 2019
@cpcloud cpcloud deleted the fix-bigquery-auth-ci branch March 20, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis ci Continuous Integration issues or PRs tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants