Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README reference to MapD to say OmniSci #1749

Merged
merged 1 commit into from Mar 26, 2019

Conversation

Projects
2 participants
@randyzwitch
Copy link
Contributor

commented Mar 26, 2019

Update MapD references to OmniSci

Update README.md
Update MapD references to OmniSci

@cpcloud cpcloud added this to the Next Bugfix Release milestone Mar 26, 2019

@cpcloud cpcloud added this to In progress in OmniSci via automation Mar 26, 2019

@cpcloud

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

I'm happy to rename other things as well (ideally preserving backwards compatibility). Is there anything else you want to rename?

@randyzwitch

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

I just targeted the README since it was pointing to the wrong website link. How things change inside the codebase is probably a much larger effort, and probably should coordinate with @xmnlab.

@codecov

This comment has been minimized.

Copy link

commented Mar 26, 2019

Codecov Report

Merging #1749 into master will decrease coverage by 1.9%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1749      +/-   ##
==========================================
- Coverage   87.33%   85.42%   -1.91%     
==========================================
  Files          80       80              
  Lines       15037    15037              
  Branches     1923     1923              
==========================================
- Hits        13132    12846     -286     
- Misses       1558     1846     +288     
+ Partials      347      345       -2
Impacted Files Coverage Δ
ibis/bigquery/client.py 41.1% <0%> (-53.39%) ⬇️
ibis/bigquery/compiler.py 58.67% <0%> (-38.75%) ⬇️
ibis/bigquery/udf/api.py 80.48% <0%> (-14.64%) ⬇️
ibis/bigquery/api.py 63.33% <0%> (-10.01%) ⬇️
ibis/impala/compiler.py 91.04% <0%> (-5.75%) ⬇️
ibis/pandas/client.py 86.54% <0%> (-3.51%) ⬇️
ibis/expr/schema.py 89.77% <0%> (-1.14%) ⬇️
ibis/expr/window.py 86.77% <0%> (-0.83%) ⬇️
ibis/expr/api.py 93.55% <0%> (-0.4%) ⬇️
ibis/sql/compiler.py 93.7% <0%> (-0.39%) ⬇️
... and 2 more

OmniSci automation moved this from In progress to Reviewer approved Mar 26, 2019

@cpcloud cpcloud merged commit 1b40fea into ibis-project:master Mar 26, 2019

6 of 7 checks passed

codecov/project 85.42% (-1.91%) compared to 33201ac
Details
ci/circleci: python36_benchmark Your tests passed on CircleCI!
Details
ci/circleci: python36_docs Your tests passed on CircleCI!
Details
ci/circleci: python36_test Your tests passed on CircleCI!
Details
ci/circleci: python37_test Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 33201ac...9a88a7e
Details
ibis-project.ibis Build #20190326.2 succeeded
Details

OmniSci automation moved this from Reviewer approved to Done Mar 26, 2019

@randyzwitch randyzwitch deleted the randyzwitch:patch-1 branch Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.