ENH: Rewrite pandas execution to use topological sort instead of recursion #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
commented
Apr 13, 2019
cpcloud
force-pushed
the
pandas-toposort
branch
3 times, most recently
from
a72c22c
to
a341862
Compare
cpcloud
added
feature
cpcloud
force-pushed
the
pandas-toposort
branch
from
5e39a72
to
6a050a4
Compare
toryhaavik
reviewed
Apr 16, 2019
toryhaavik
reviewed
Apr 16, 2019
toryhaavik
reviewed
Apr 16, 2019
| # compute the nodes that are not currently in scope | ||
| for node in nodes: | ||
| # allow clients to pre compute nodes as they like | ||
| pre_executed_scope = pre_execute( |
There was a problem hiding this comment.
we should talk about this a bit. based on the naming, i would expect pre_execute to happen before execute_first. and i think executing pre_execute in a loop over each node is a little different than how it happens now. we may not have good test cases that exercise the nuances of pre_execute here.
toryhaavik
reviewed
Apr 16, 2019
| type(query).__name__ | ||
| ) | ||
| ) | ||
| return execute_last( |
There was a problem hiding this comment.
why wouldn't this be part of the main execute? each client needs to call execute_last, and if i call the execution function rather than this method, i won't get the execute_last behavior.
There was a problem hiding this comment.
Because execute_last will always reset the index because of the default implementation. Window function execution requires the index to be preserved, and it makes recursive calls to execute which means we cannot reset the index.
cpcloud
force-pushed
the
pandas-toposort
branch
4 times, most recently
from
5ba02f0
to
c7df2d1
Compare
cpcloud
force-pushed
the
pandas-toposort
branch
from
c7df2d1
to
43d1725
Compare
cpcloud
force-pushed
the
pandas-toposort
branch
2 times, most recently
from
97b3de5
to
9f552a5
Compare
cpcloud
added a commit
that referenced
this pull request
Jun 19, 2019
This caused a few failures with downstream code, so I've reverted the changes to ibis/pandas/core.py. I've left other fixes from #1758 unchanged. I'll revisit the reimplementation in the near future. Author: Phillip Cloud <cpcloud@gmail.com> Closes #1837 from cpcloud/revert-topo and squashes the following commits: c9662ac [Phillip Cloud] Just pass kwargs through 5d8ec82 [Phillip Cloud] Make zero argument UDFs work again 9fa4481 [Phillip Cloud] Revert toposort change d9c00ef [Phillip Cloud] Remove unnecessary code deed6aa [Phillip Cloud] Revert select parts
cpcloud
added a commit
that referenced
this pull request
Jun 20, 2019
Example run: ``` $ dev/genrelease.py 1.2.0 * :release:`1.2.0 2019-06-19` * 🐛`1842 major` Add max_lookback to window replace and combine functions * 🐛`1837 major` Partially revert #1758 * :support:`1839` Tighter version spec for pytest * :support:`1838` allow pandas timedelta in rows_with_max_lookback * :support:`1825` Accept rows-with-max-lookback as preceding parameter * :support:`1786` PostGIS support * :support:`1826` Allow passing a branch to ci/feedstock.py ``` Author: Phillip Cloud <cpcloud@gmail.com> Closes #1845 from cpcloud/release-note-generator and squashes the following commits: 4e7eae1 [Phillip Cloud] Add rls/release to roles f260477 [Phillip Cloud] SUPP: Generate release notes from commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @toryhaavik for review