Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix preceding and following with None #1765

Merged
merged 2 commits into from Apr 22, 2019

Conversation

2 participants
@cpcloud
Copy link
Member

commented Apr 22, 2019

Before this PR, calls like

ibis.window(preceding=(None, 1))  # ROWS BETWEEN UNBOUNDED PRECEDING AND 1 PRECEDING
ibis.window(following=(1, None))  # ROWS BETWEEN 1 FOLLOWING AND UNBOUNDED FOLLOWING

would fail because of incorrect usage of comparison operators, comparing
None to another value that is not None raising a TypeError.

This PR addresses the problem.

@cpcloud cpcloud added this to the Next Feature Release milestone Apr 22, 2019

@cpcloud cpcloud added this to To do in Impala via automation Apr 22, 2019

@cpcloud cpcloud added this to To do in BigQuery via automation Apr 22, 2019

Show resolved Hide resolved ibis/expr/window.py Outdated
Show resolved Hide resolved ibis/expr/window.py Outdated

@cpcloud cpcloud force-pushed the cpcloud:fix-prec-foll-unbounded branch from 73e84a6 to a9ce03f Apr 22, 2019

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2019

Thanks for the review @ash32 I ended up doing it slightly different, but the end result was the same (checking the value of start/end regardless of whether its counterpart was None).

@cpcloud cpcloud merged commit 1e39a5f into ibis-project:master Apr 22, 2019

13 checks passed

ci/circleci: python35_test Your tests passed on CircleCI!
Details
ci/circleci: python36_benchmark Your tests passed on CircleCI!
Details
ci/circleci: python36_conda_build Your tests passed on CircleCI!
Details
ci/circleci: python36_docs Your tests passed on CircleCI!
Details
ci/circleci: python36_test Your tests passed on CircleCI!
Details
ci/circleci: python37_conda_build Your tests passed on CircleCI!
Details
ci/circleci: python37_test Your tests passed on CircleCI!
Details
ibis-project.ibis Build #20190422.5 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py36) WindowsCondaBuild py36 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py37) WindowsCondaBuild py37 succeeded
Details
ibis-project.ibis (WindowsTest py35) WindowsTest py35 succeeded
Details
ibis-project.ibis (WindowsTest py36) WindowsTest py36 succeeded
Details
ibis-project.ibis (WindowsTest py37) WindowsTest py37 succeeded
Details

BigQuery automation moved this from To do to Done Apr 22, 2019

Impala automation moved this from To do to Done Apr 22, 2019

@cpcloud cpcloud deleted the cpcloud:fix-prec-foll-unbounded branch Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.