Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes DOC: conda create command listed no longer works #1775

Merged
merged 1 commit into from May 11, 2019

Conversation

2 participants
@scottcode
Copy link
Contributor

commented May 10, 2019

Fixes error in documentation, issue #1774

The following command in developer.rst no longer works for two reasons. One, the YAML file no longer exists. Two, creating a conda environment from YAML needs to be done with conda env create instead of conda create.

Failing instruction:
conda create -n ibis36 -c conda-forge --file=ci/requirements-dev.yml python=3.6

Should now be:
conda env create -n ibis36 -f ci/requirements-3.6-dev.yml

The following command in `developer.rst` no longer works for two reas…
…ons. One, the YAML file no longer exists. Two, creating a conda environment from YAML needs to be done with `conda env create` instead of `conda create`.

Failing instruction:
`conda create -n ibis36 -c conda-forge --file=ci/requirements-dev.yml python=3.6`

Should now be:
`conda env create -n ibis36 -f ci/requirements-3.6-dev.yml`
@scottcode

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

I'm new to contributing to projects like this, so if there are any formalities or technicalities that I need to tweak to make this contribution possible, please let me know. I am open to guidance. Thanks to the community for how awesome ibis already is, and I hope to become part of your community.

@cpcloud cpcloud added this to the Next Feature Release milestone May 11, 2019

@cpcloud cpcloud added this to To do in Documentation via automation May 11, 2019

@cpcloud cpcloud self-assigned this May 11, 2019

@cpcloud

This comment has been minimized.

Copy link
Member

commented May 11, 2019

@scottcode Merging, thanks!

@cpcloud cpcloud merged commit 2695e84 into ibis-project:master May 11, 2019

10 of 13 checks passed

ci/circleci: python36_docs Your tests failed on CircleCI
Details
ci/circleci: python36_test Your tests failed on CircleCI
Details
ci/circleci: python37_test Your tests failed on CircleCI
Details
ci/circleci: python35_test Your tests passed on CircleCI!
Details
ci/circleci: python36_benchmark Your tests passed on CircleCI!
Details
ci/circleci: python36_conda_build Your tests passed on CircleCI!
Details
ci/circleci: python37_conda_build Your tests passed on CircleCI!
Details
ibis-project.ibis Build #20190510.3 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py36) WindowsCondaBuild py36 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py37) WindowsCondaBuild py37 succeeded
Details
ibis-project.ibis (WindowsTest py35) WindowsTest py35 succeeded
Details
ibis-project.ibis (WindowsTest py36) WindowsTest py36 succeeded
Details
ibis-project.ibis (WindowsTest py37) WindowsTest py37 succeeded
Details

Documentation automation moved this from To do to Done May 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.