Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH/CLN: Enable window function tests where possible #1777

Merged
merged 6 commits into from May 12, 2019

Conversation

Projects
2 participants
@cpcloud
Copy link
Member

commented May 11, 2019

No description provided.

@cpcloud cpcloud requested a review from xmnlab May 11, 2019

@cpcloud cpcloud added the testing label May 11, 2019

@cpcloud cpcloud added this to To do in Refactoring via automation May 11, 2019

@cpcloud cpcloud force-pushed the cpcloud:fix-window-test branch from 18059b3 to 130e2bb May 11, 2019

@xmnlab
Copy link
Collaborator

left a comment

it seem awesome @cpcloud
I just added some comment related to the old code that maybe would be good to change (just move up a bit one line)

the current testes that are failing are:

FAILED ibis/tests/all/test_window.py::test_window[PostgreSQL-rank]
FAILED ibis/tests/all/test_window.py::test_window[PostgreSQL-dense_rank]
FAILED ibis/tests/all/test_window.py::test_window[BigQuery-lag]
FAILED ibis/tests/all/test_window.py::test_window[BigQuery-lead]
FAILED ibis/tests/all/test_window.py::test_window[BigQuery-rank]
FAILED ibis/tests/all/test_window.py::test_window[BigQuery-dense_rank]
FAILED ibis/tests/all/test_window.py::test_window[BigQuery-percent_rank]
FAILED ibis/tests/all/test_window.py::test_window[Impala-lag]
FAILED ibis/tests/all/test_window.py::test_window[Impala-lead]
FAILED ibis/tests/all/test_window.py::test_window[Impala-rank]
FAILED ibis/tests/all/test_window.py::test_window[Impala-dense_rank]

related to the error:

E       AssertionError: Attributes are different
E       
E       Attribute "dtype" are different
E       [left]:  int64
E       [right]: float64

not sure ... but if the result should be integer, so the expected value maybe could be converted to float if it has NA values .. but I need to check the code locally to be sure of this error

Show resolved Hide resolved ibis/tests/all/test_window.py

@cpcloud cpcloud merged commit cd33e18 into ibis-project:master May 12, 2019

13 checks passed

ci/circleci: python35_test Your tests passed on CircleCI!
Details
ci/circleci: python36_benchmark Your tests passed on CircleCI!
Details
ci/circleci: python36_conda_build Your tests passed on CircleCI!
Details
ci/circleci: python36_docs Your tests passed on CircleCI!
Details
ci/circleci: python36_test Your tests passed on CircleCI!
Details
ci/circleci: python37_conda_build Your tests passed on CircleCI!
Details
ci/circleci: python37_test Your tests passed on CircleCI!
Details
ibis-project.ibis Build #20190512.1 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py36) WindowsCondaBuild py36 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py37) WindowsCondaBuild py37 succeeded
Details
ibis-project.ibis (WindowsTest py35) WindowsTest py35 succeeded
Details
ibis-project.ibis (WindowsTest py36) WindowsTest py36 succeeded
Details
ibis-project.ibis (WindowsTest py37) WindowsTest py37 succeeded
Details

Refactoring automation moved this from To do to Done May 12, 2019

@cpcloud cpcloud deleted the cpcloud:fix-window-test branch May 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.