Clean up most xpassing tests #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
force-pushed
the
cleanup-xpass-tests
branch
2 times, most recently
from
6e4c86d
to
2e605d9
Compare
cpcloud
added
refactor
|
Merging on green. |
cpcloud
force-pushed
the
cleanup-xpass-tests
branch
from
92f694e
to
6af2883
Compare
cpcloud
force-pushed
the
cleanup-xpass-tests
branch
from
6af2883
to
5290185
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes all
XPASSing tests pass in the typical way, by customizing thebehavior of two fixtures
xfail_backends(all listed backends are permitted tofail) and
xpass_backends(all backends not listed are permitted to fail)I've also added
xfail_strict = truetosetup.cfgto make sure that we don't introduce anyXPASSing tests in the future. Of course, that's always up for debate in the future but I think there's probably a way to customizexfails similar to what I've done here such that we don't need to have any futureXPASSes.