Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up most xpassing tests #1779

Merged
merged 1 commit into from May 15, 2019

Conversation

Projects
1 participant
@cpcloud
Copy link
Member

commented May 12, 2019

This PR makes all XPASSing tests pass in the typical way, by customizing the
behavior of two fixtures xfail_backends (all listed backends are permitted to
fail) and xpass_backends (all backends not listed are permitted to fail)

I've also added xfail_strict = true to setup.cfg to make sure that we don't introduce any XPASSing tests in the future. Of course, that's always up for debate in the future but I think there's probably a way to customize xfails similar to what I've done here such that we don't need to have any future XPASSes.

@cpcloud cpcloud force-pushed the cpcloud:cleanup-xpass-tests branch 2 times, most recently from 6e4c86d to 2e605d9 May 12, 2019

@cpcloud cpcloud added this to To do in Refactoring via automation May 13, 2019

@cpcloud cpcloud added this to the Next Feature Release milestone May 13, 2019

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

Merging on green.

@cpcloud cpcloud force-pushed the cpcloud:cleanup-xpass-tests branch from 92f694e to 6af2883 May 13, 2019

@cpcloud cpcloud force-pushed the cpcloud:cleanup-xpass-tests branch from 6af2883 to 5290185 May 15, 2019

@cpcloud cpcloud merged commit f9ed5ff into ibis-project:master May 15, 2019

13 checks passed

ci/circleci: python35_test Your tests passed on CircleCI!
Details
ci/circleci: python36_benchmark Your tests passed on CircleCI!
Details
ci/circleci: python36_conda_build Your tests passed on CircleCI!
Details
ci/circleci: python36_docs Your tests passed on CircleCI!
Details
ci/circleci: python36_test Your tests passed on CircleCI!
Details
ci/circleci: python37_conda_build Your tests passed on CircleCI!
Details
ci/circleci: python37_test Your tests passed on CircleCI!
Details
ibis-project.ibis Build #20190515.2 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py36) WindowsCondaBuild py36 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py37) WindowsCondaBuild py37 succeeded
Details
ibis-project.ibis (WindowsTest py35) WindowsTest py35 succeeded
Details
ibis-project.ibis (WindowsTest py36) WindowsTest py36 succeeded
Details
ibis-project.ibis (WindowsTest py37) WindowsTest py37 succeeded
Details

Refactoring automation moved this from To do to Done May 15, 2019

@cpcloud cpcloud deleted the cpcloud:cleanup-xpass-tests branch May 15, 2019

@cpcloud cpcloud referenced this pull request May 16, 2019

Closed

window operation test #1770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.