Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH/CI: MapD/OmniSci Update ci to use newest omnisci docker #1781

Merged
merged 2 commits into from May 13, 2019

Conversation

Projects
None yet
2 participants
@xmnlab
Copy link
Collaborator

commented May 13, 2019

No description provided.

xmnlab added some commits May 13, 2019

@codecov

This comment has been minimized.

Copy link

commented May 13, 2019

Codecov Report

Merging #1781 into master will decrease coverage by 1.89%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1781     +/-   ##
=========================================
- Coverage   87.66%   85.77%   -1.9%     
=========================================
  Files          80       80             
  Lines       15074    15074             
  Branches     1940     1940             
=========================================
- Hits        13215    12929    -286     
- Misses       1508     1796    +288     
+ Partials      351      349      -2
Impacted Files Coverage Δ
ibis/mapd/api.py 61.11% <ø> (ø) ⬆️
ibis/mapd/client.py 54.34% <ø> (ø) ⬆️
ibis/bigquery/client.py 41.1% <0%> (-53.39%) ⬇️
ibis/bigquery/compiler.py 58.67% <0%> (-38.75%) ⬇️
ibis/bigquery/udf/api.py 80.48% <0%> (-14.64%) ⬇️
ibis/bigquery/api.py 63.33% <0%> (-10.01%) ⬇️
ibis/impala/compiler.py 91.28% <0%> (-5.6%) ⬇️
ibis/pandas/client.py 86.54% <0%> (-3.51%) ⬇️
ibis/expr/schema.py 89.77% <0%> (-1.14%) ⬇️
ibis/expr/window.py 86.46% <0%> (-0.76%) ⬇️
... and 4 more

@xmnlab xmnlab marked this pull request as ready for review May 13, 2019

@xmnlab xmnlab requested a review from cpcloud May 13, 2019

@xmnlab

This comment has been minimized.

Copy link
Collaborator Author

commented May 13, 2019

@cpcloud it is done for a review :)

@xmnlab xmnlab referenced this pull request May 13, 2019

Merged

First version of omnisci window op #1771

8 of 8 tasks complete
@cpcloud
Copy link
Member

left a comment

LGTM, merging.

@cpcloud cpcloud merged commit f48586b into ibis-project:master May 13, 2019

14 of 15 checks passed

codecov/project 85.77% (-1.9%) compared to 0af3f92
Details
ci/circleci: python35_test Your tests passed on CircleCI!
Details
ci/circleci: python36_benchmark Your tests passed on CircleCI!
Details
ci/circleci: python36_conda_build Your tests passed on CircleCI!
Details
ci/circleci: python36_docs Your tests passed on CircleCI!
Details
ci/circleci: python36_test Your tests passed on CircleCI!
Details
ci/circleci: python37_conda_build Your tests passed on CircleCI!
Details
ci/circleci: python37_test Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 0af3f92...7c11720
Details
ibis-project.ibis Build #20190513.3 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py36) WindowsCondaBuild py36 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py37) WindowsCondaBuild py37 succeeded
Details
ibis-project.ibis (WindowsTest py35) WindowsTest py35 succeeded
Details
ibis-project.ibis (WindowsTest py36) WindowsTest py36 succeeded
Details
ibis-project.ibis (WindowsTest py37) WindowsTest py37 succeeded
Details
@cpcloud

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Thanks @xmnlab!

@cpcloud cpcloud added this to the Next Feature Release milestone May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.