Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
FEAT: PostGIS support #1787
Thanks for the tip @xmnlab. At this point a lot of the functionality I'm looking for is in, but it needs a lot of testing. Any tips as to how to go about that? In particular, it would be useful to have a PostGIS-enabled PostgreSQL and a Spatialite-enabled SQLite in CI.
@@ Coverage Diff @@ ## master #1787 +/- ## ========================================== - Coverage 87.33% 85.45% -1.88% ========================================== Files 81 80 -1 Lines 15266 15219 -47 Branches 1965 1956 -9 ========================================== - Hits 13333 13006 -327 - Misses 1567 1860 +293 + Partials 366 353 -13
hey @ian-r-rose you can add the tests here: https://github.com/ibis-project/ibis/blob/f6220bb29ea05035ebeb44437c7db36ce0ba8562/ibis/tests/all/test_geospatial.py
related to postgis, you can try to change
probably you will need to add the the new libs you are using to ci/requirements-dev yaml files
related to spatialite extension ... not sure .. maybe you need to add
maybe you also will need to change something here:
@cpcloud what do you think about this?
Okay, I think this is close-to-ready for some feedback. Tests are mostly passing except for docs (any idea what is going on there?), and most of the functionality I am looking for is in.
There are still some tests to write, and some coverage to improve, but querying geospatial data with PostGIS basically works!
I've made a demonstration gist showing this PR in action: https://gist.github.com/ian-r-rose/255295a5a98ca59259b55aee9a7cfdae
It's a little hokey, but shows some non-trivial geospatial operations.
Jun 17, 2019
13 checks passed
referenced this pull request
Jun 17, 2019
awesome! this is how geo literals were implemented on mapd: https://github.com/ibis-project/ibis/blob/master/ibis/mapd/operations.py#L390
I think you can add these translations here for postgis: https://github.com/ibis-project/ibis/blob/master/ibis/sql/postgres/compiler.py#L585