Mapd session #1796
Mapd session #1796
Conversation
|
Thanks for the review @cpcloud! |
@ian-r-rose Can you take a look at this and make sure that it matches our discussion re OmniSci on #1796? Author: Phillip Cloud <cpcloud@gmail.com> Closes #1798 from cpcloud/fix-py35-deps and squashes the following commits: 2bace3f [Phillip Cloud] Add pydata-google-auth to pip deps in conda env requirements 4216d7a [Phillip Cloud] Fix Python 3.5 dependency versions
|
@ian-r-rose Can you rebase to pick up the changes from #1798? |
ian-r-rose
force-pushed
the
mapd-session-id
branch
from
0d646ac
to
403cbef
Compare
ian-r-rose
force-pushed
the
mapd-session-id
branch
from
2b2cafb
to
c60e105
Compare
|
@ian-r-rose Looks like there's a test failing that's related to your changes: https://circleci.com/gh/ian-r-rose/ibis/80?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link |
ibis/mapd/client.py
Outdated
| ) | ||
| if session_id: | ||
| if self.version < pkg_resources.parse_version('0.12.0'): | ||
| raise Exception('Must have pympad > 0.12 to use session ID') |
There was a problem hiding this comment.
Can you add an Exception subclass for this? E.g., PyMapDVersionError. There's also a typo in pympad.
|
@cpcloud @ian-r-rose it would also be helpful if one could pass an existing pymapd connection object to Ibis instead of having to build a connection every time. Is this something we could / should include in this PR? |
|
LGTM. Merging! Thanks. |
|
@jp-harvey I think we'd probably want another API like |
|
Awesome, thanks for the reviews @cpcloud! Do you have any thoughts about @jp-harvey's suggestion? |
pymapdrecently gained the ability to connect via a pre-authenticated session ID. It would be nice if the Ibis mapd connector could do that as well. cc @xmnlab