Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG/CI/BLD: Fix Python 3.5 dependency versions #1798

Merged
merged 2 commits into from
May 27, 2019
Merged

BUG/CI/BLD: Fix Python 3.5 dependency versions #1798

merged 2 commits into from
May 27, 2019

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented May 26, 2019 •
edited
Loading

@ian-r-rose Can you take a look at this and make sure that it matches our discussion re OmniSci on #1796?

@cpcloud cpcloud added this to the 1.1.0 milestone May 26, 2019
@cpcloud cpcloud added bug Incorrect behavior inside of ibis ci Continuous Integration issues or PRs omnisci labels May 26, 2019
@ian-r-rose
Copy link
Contributor

Thanks @cpcloud, this looks consistent to me. With regards to #1796, is there currently a way to mark a test/fixture to not run on Python 3.5?

@cpcloud
Copy link
Member Author

cpcloud commented May 26, 2019

Yep, you can decorate an individual test with pytest.mark.skipif(some_condition). See here: https://docs.pytest.org/en/latest/skipping.html#id1

@cpcloud cpcloud merged commit 3c7e244 into ibis-project:master May 27, 2019
@cpcloud cpcloud deleted the fix-py35-deps branch May 27, 2019 01:32
@cpcloud cpcloud self-assigned this May 27, 2019
@cpcloud cpcloud mentioned this pull request May 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cpcloud cpcloud

Labels
bug Incorrect behavior inside of ibis ci Continuous Integration issues or PRs
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @ian-r-rose