Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/CI/BLD: Fix Python 3.5 dependency versions #1798

Merged
merged 2 commits into from May 27, 2019

Conversation

Projects
2 participants
@cpcloud
Copy link
Member

commented May 26, 2019

@ian-r-rose Can you take a look at this and make sure that it matches our discussion re OmniSci on #1796?

@cpcloud cpcloud added this to the 1.1.0 milestone May 26, 2019

@cpcloud cpcloud added this to In progress in OmniSci via automation May 26, 2019

@ian-r-rose

This comment has been minimized.

Copy link
Contributor

commented May 26, 2019

Thanks @cpcloud, this looks consistent to me. With regards to #1796, is there currently a way to mark a test/fixture to not run on Python 3.5?

@cpcloud

This comment has been minimized.

Copy link
Member Author

commented May 26, 2019

Yep, you can decorate an individual test with pytest.mark.skipif(some_condition). See here: https://docs.pytest.org/en/latest/skipping.html#id1

@cpcloud cpcloud merged commit 3c7e244 into ibis-project:master May 27, 2019

13 checks passed

ci/circleci: python35_test Your tests passed on CircleCI!
Details
ci/circleci: python36_benchmark Your tests passed on CircleCI!
Details
ci/circleci: python36_conda_build Your tests passed on CircleCI!
Details
ci/circleci: python36_docs Your tests passed on CircleCI!
Details
ci/circleci: python36_test Your tests passed on CircleCI!
Details
ci/circleci: python37_conda_build Your tests passed on CircleCI!
Details
ci/circleci: python37_test Your tests passed on CircleCI!
Details
ibis-project.ibis Build #20190526.2 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py36) WindowsCondaBuild py36 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py37) WindowsCondaBuild py37 succeeded
Details
ibis-project.ibis (WindowsTest py35) WindowsTest py35 succeeded
Details
ibis-project.ibis (WindowsTest py36) WindowsTest py36 succeeded
Details
ibis-project.ibis (WindowsTest py37) WindowsTest py37 succeeded
Details

OmniSci automation moved this from In progress to Done May 27, 2019

@cpcloud cpcloud deleted the cpcloud:fix-py35-deps branch May 27, 2019

@cpcloud cpcloud self-assigned this May 27, 2019

@cpcloud cpcloud referenced this pull request May 27, 2019

Merged

Mapd session #1796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.