Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Spark client #1807

Merged
merged 14 commits into from
Jul 3, 2019
Merged

FEAT: Spark client #1807

merged 14 commits into from
Jul 3, 2019

Conversation

amroid
Copy link
Contributor

@amroid amroid commented Jun 5, 2019

No description provided.

@pep8speaks
Copy link

pep8speaks commented Jun 5, 2019 •
edited
Loading

Hello @amroid! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-07-03 15:54:12 UTC

@xmnlab
Copy link
Contributor

xmnlab commented Jun 5, 2019

hey @amroid! thanks for your PR. it seems there are some pep8 issues, did you run make develop locally (https://github.com/ibis-project/ibis/blob/master/Makefile#L18)? it install some nice tools on git pre-commit hook such as black and flake8 (https://github.com/ibis-project/ibis/blob/master/.pre-commit-config.yaml) maybe it would help you :)

@cpcloud cpcloud added the spark label Jun 6, 2019
@cpcloud cpcloud added this to the Next Feature Release milestone Jun 6, 2019
cpcloud
cpcloud requested changes Jun 6, 2019
View reviewed changes
ibis/__init__.py Show resolved Hide resolved
ibis/spark/compiler.py Outdated Show resolved Hide resolved
ibis/spark/tests/test_client.py Outdated Show resolved Hide resolved
ibis/spark/tests/test_client.py Outdated Show resolved Hide resolved
ibis/spark/compiler.py Outdated Show resolved Hide resolved
ibis/spark/compiler.py Outdated Show resolved Hide resolved
ibis/spark/compiler.py Outdated Show resolved Hide resolved
@cpcloud cpcloud added the feature Features or general enhancements label Jun 6, 2019
@cpcloud cpcloud self-assigned this Jun 6, 2019
cpcloud
cpcloud requested changes Jun 18, 2019
View reviewed changes
ibis/spark/api.py Outdated Show resolved Hide resolved
ibis/spark/client.py Outdated Show resolved Hide resolved
ibis/spark/client.py Outdated Show resolved Hide resolved
ibis/spark/client.py Show resolved Hide resolved
ibis/spark/client.py Outdated Show resolved Hide resolved
ibis/spark/client.py Show resolved Hide resolved
ibis/spark/client.py Outdated Show resolved Hide resolved
ibis/spark/compiler.py Outdated Show resolved Hide resolved
@cpcloud cpcloud mentioned this pull request Jun 19, 2019
Closed
@cpcloud cpcloud changed the title Spark client FEAT: Spark client Jun 20, 2019
@cpcloud cpcloud modified the milestones: 1.2.0, Next Feature Release Jun 24, 2019
cpcloud
cpcloud requested changes Jul 2, 2019
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more comments, very close!

ibis/spark/client.py Outdated Show resolved Hide resolved
ibis/spark/client.py Outdated Show resolved Hide resolved
ibis/spark/client.py Outdated Show resolved Hide resolved
ibis/spark/compiler.py Outdated Show resolved Hide resolved
ibis/spark/compiler.py Outdated Show resolved Hide resolved
ibis/spark/tests/conftest.py Outdated Show resolved Hide resolved
ibis/spark/tests/test_client.py Outdated Show resolved Hide resolved
cpcloud
cpcloud requested changes Jul 3, 2019
View reviewed changes
ibis/spark/client.py Outdated Show resolved Hide resolved
ibis/spark/tests/test_client.py Outdated Show resolved Hide resolved
@amroid
Improve schema checks in spark test_client.py, xfail map<struct<...>,…
83a50e8 
… ...> schema conversion test, fix results parameter in _execute in spark client
cpcloud
cpcloud approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Approved.

@cpcloud
Copy link
Member

cpcloud commented Jul 3, 2019

Merging!

@cpcloud cpcloud merged commit 3afa8b0 into ibis-project:master Jul 3, 2019
@cpcloud
Copy link
Member

cpcloud commented Jul 3, 2019

@amroid Feel free to delete your branch if you want, but not necessary.

@amroid amroid deleted the spark-client branch July 5, 2019 13:38
This was referenced Jul 18, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees

@cpcloud cpcloud

Labels
feature Features or general enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amroid @pep8speaks @xmnlab @cpcloud