Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate trailing window functions #1809

Merged
merged 4 commits into from Jun 8, 2019

Conversation

Projects
None yet
2 participants
@emilyreff7
Copy link
Contributor

commented Jun 6, 2019

This constitutes one step of several required to extend Ibis trailing window functionality, where trailing_window will become more extensible to support various types of 'preceding' parameters. In this first step, trailing_window is able to handle not only integers but ibis intervals as well, using the type of the 'preceding' parameter to determine the 'how' of the window.

@cpcloud

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

@emilyreff7 Can you pull in master to pick up the fix from #1811? I'll review in the meantime.

@cpcloud cpcloud self-assigned this Jun 6, 2019

@emilyreff7

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

@emilyreff7 Can you pull in master to pick up the fix from #1811? I'll review in the meantime.

Yes, checks are passing now. :)

@cpcloud cpcloud added the enhancement label Jun 6, 2019

Show resolved Hide resolved ibis/expr/window.py Outdated
@cpcloud
Copy link
Member

left a comment

Final change request, then this is good to go.

Show resolved Hide resolved ibis/expr/window.py Outdated

@cpcloud cpcloud added this to the 1.1.0 milestone Jun 7, 2019

@cpcloud cpcloud merged commit e634fa3 into ibis-project:master Jun 8, 2019

13 checks passed

ci/circleci: python35_test Your tests passed on CircleCI!
Details
ci/circleci: python36_benchmark Your tests passed on CircleCI!
Details
ci/circleci: python36_conda_build Your tests passed on CircleCI!
Details
ci/circleci: python36_docs Your tests passed on CircleCI!
Details
ci/circleci: python36_test Your tests passed on CircleCI!
Details
ci/circleci: python37_conda_build Your tests passed on CircleCI!
Details
ci/circleci: python37_test Your tests passed on CircleCI!
Details
ibis-project.ibis Build #20190607.4 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py36) WindowsCondaBuild py36 succeeded
Details
ibis-project.ibis (WindowsCondaBuild py37) WindowsCondaBuild py37 succeeded
Details
ibis-project.ibis (WindowsTest py35) WindowsTest py35 succeeded
Details
ibis-project.ibis (WindowsTest py36) WindowsTest py36 succeeded
Details
ibis-project.ibis (WindowsTest py37) WindowsTest py37 succeeded
Details

@emilyreff7 emilyreff7 deleted the emilyreff7:window branch Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.