Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix failing strftime tests on Python 3.7 #1818

Merged
merged 1 commit into from
Jun 10, 2019
Merged

BUG: Fix failing strftime tests on Python 3.7 #1818

merged 1 commit into from
Jun 10, 2019

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jun 9, 2019

Also address the warnings about unknown marks coming from newer versions of
pytest

Closes #1699
Closes #1808

@cpcloud cpcloud added this to the 1.1.0 milestone Jun 9, 2019
@cpcloud cpcloud added bug Incorrect behavior inside of ibis postgres The PostgreSQL backend tests Issues or PRs related to tests labels Jun 9, 2019
@cpcloud cpcloud self-assigned this Jun 9, 2019
@cpcloud cpcloud changed the title Fix failing strftime tests on Python 3.7 BUG: Fix failing strftime tests on Python 3.7 Jun 9, 2019
@cpcloud cpcloud force-pushed the fix-pg-strftime branch 2 times, most recently from 9bf865c to e0c9cc8 Compare June 9, 2019 21:37
@pep8speaks
Copy link

pep8speaks commented Jun 9, 2019 •
edited
Loading

Hello @cpcloud! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-06-09 23:10:55 UTC

@cpcloud cpcloud merged commit ec138f0 into ibis-project:master Jun 10, 2019
@cpcloud cpcloud deleted the fix-pg-strftime branch June 10, 2019 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cpcloud cpcloud

Labels
bug Incorrect behavior inside of ibis postgres The PostgreSQL backend tests Issues or PRs related to tests
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Newer pytest warns about unknown marks (4.5.0) Strftime quoting error with postgres backend on python 3.7
2 participants
@cpcloud @pep8speaks