Accept rows-with-max-lookback as preceding parameter #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
feature
cpcloud
reviewed
Jun 12, 2019
cpcloud
reviewed
Jun 17, 2019
cpcloud
reviewed
Jun 17, 2019
cpcloud
reviewed
Jun 17, 2019
cpcloud
reviewed
Jun 17, 2019
cpcloud
requested changes
Jun 17, 2019
cpcloud
reviewed
Jun 17, 2019
| @@ -163,6 +203,12 @@ def _validate_frame(self): | |||
| "'how' must be 'rows' or 'range', got {}".format(self.how) | |||
| ) | |||
|
|
|||
| if self.max_lookback is not None: | |||
| if not isinstance(self.max_lookback, ir.IntervalValue): | |||
There was a problem hiding this comment.
I'll make a follow up for this, but I think we might also want to support passing in pandas.Timedelta objects here.
cpcloud
reviewed
Jun 17, 2019
| ibis.trailing_window( | ||
| rows_with_max_lookback(3, ibis.interval(days=3)) | ||
| ), | ||
| 'rows between 3 preceding and current row', |
There was a problem hiding this comment.
I'll create a follow up issue for this as well, but I don't think we should implement this for any backends unless we can give it well-defined behavior.
This was referenced Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support row-based trailing windows bound by a maximum look-back period